2013-06-04 21:19:38

by Matthias Kaehlcke

[permalink] [raw]
Subject: [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers

The command and status register in the driver were swapped with
respect to the order specified in the datasheet (CY8CTMA140).
Confirmed with Cypress that the order in the datasheet is correct.

Signed-off-by: Matthias Kaehlcke <[email protected]>
---
drivers/input/touchscreen/cyttsp_core.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/cyttsp_core.h b/drivers/input/touchscreen/cyttsp_core.h
index 1aa3c69..f1ebde3 100644
--- a/drivers/input/touchscreen/cyttsp_core.h
+++ b/drivers/input/touchscreen/cyttsp_core.h
@@ -67,8 +67,8 @@ struct cyttsp_xydata {
/* TTSP System Information interface definition */
struct cyttsp_sysinfo_data {
u8 hst_mode;
- u8 mfg_cmd;
u8 mfg_stat;
+ u8 mfg_cmd;
u8 cid[3];
u8 tt_undef1;
u8 uid[8];
--
1.7.10.4


2013-06-05 09:21:58

by Javier Martinez Canillas

[permalink] [raw]
Subject: Re: [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers

On Tue, Jun 4, 2013 at 11:19 PM, Matthias Kaehlcke
<[email protected]> wrote:
> The command and status register in the driver were swapped with
> respect to the order specified in the datasheet (CY8CTMA140).
> Confirmed with Cypress that the order in the datasheet is correct.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> ---

Acked-by: Javier Martinez Canillas <[email protected]>

2013-06-10 11:03:05

by Ferruh Yigit

[permalink] [raw]
Subject: Re: [PATCH] cyttsp: Fix swap of mfg_stat and mfg_cmd registers

On 06/05/2013 12:21 PM, Javier Martinez Canillas wrote:
> On Tue, Jun 4, 2013 at 11:19 PM, Matthias Kaehlcke
> <[email protected]> wrote:
>> The command and status register in the driver were swapped with
>> respect to the order specified in the datasheet (CY8CTMA140).
>> Confirmed with Cypress that the order in the datasheet is correct.
>>
>> Signed-off-by: Matthias Kaehlcke <[email protected]>
>> ---
>
> Acked-by: Javier Martinez Canillas <[email protected]>

Acked-by: Ferruh Yigit <[email protected]>


This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message.