2013-06-14 12:39:24

by Zhang Yanfei

Subject: [PATCH] mm: Remove unused functions is_{normal_idx, normal, dma32, dma}

From: Zhang Yanfei <[email protected]>

These functions are nowhere used, so remove them.

Signed-off-by: Zhang Yanfei <[email protected]>
---
include/linux/mmzone.h | 28 ----------------------------
1 files changed, 0 insertions(+), 28 deletions(-)

diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 5c76737..32f0105 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -843,11 +843,6 @@ static inline int is_highmem_idx(enum zone_type idx)
#endif
}

-static inline int is_normal_idx(enum zone_type idx)
-{
- return (idx == ZONE_NORMAL);
-}
-
/**
* is_highmem - helper function to quickly check if a struct zone is a
* highmem zone or not. This is an attempt to keep references
@@ -866,29 +861,6 @@ static inline int is_highmem(struct zone *zone)
#endif
}

-static inline int is_normal(struct zone *zone)
-{
- return zone == zone->zone_pgdat->node_zones + ZONE_NORMAL;
-}
-
-static inline int is_dma32(struct zone *zone)
-{
-#ifdef CONFIG_ZONE_DMA32
- return zone == zone->zone_pgdat->node_zones + ZONE_DMA32;
-#else
- return 0;
-#endif
-}
-
-static inline int is_dma(struct zone *zone)
-{
-#ifdef CONFIG_ZONE_DMA
- return zone == zone->zone_pgdat->node_zones + ZONE_DMA;
-#else
- return 0;
-#endif
-}
-
/* These two functions are used to setup the per zone pages min values */
struct ctl_table;
int min_free_kbytes_sysctl_handler(struct ctl_table *, int,
--
1.7.1

2013-06-14 22:34:37

by Andrew Morton

Subject: Re: [PATCH] mm: Remove unused functions is_{normal_idx, normal, dma32, dma}

On Fri, 14 Jun 2013 20:39:13 +0800 Zhang Yanfei <[email protected]> wrote:

> From: Zhang Yanfei <[email protected]>
>
> These functions are nowhere used, so remove them.
>
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -843,11 +843,6 @@ static inline int is_highmem_idx(enum zone_type idx)
> #endif
> }
>
> -static inline int is_normal_idx(enum zone_type idx)
> -{
> - return (idx == ZONE_NORMAL);
> -}
> -
> /**
> * is_highmem - helper function to quickly check if a struct zone is a
> * highmem zone or not. This is an attempt to keep references
> @@ -866,29 +861,6 @@ static inline int is_highmem(struct zone *zone)
> #endif
> }
>
> -static inline int is_normal(struct zone *zone)
> -{
> - return zone == zone->zone_pgdat->node_zones + ZONE_NORMAL;
> -}
> -
> -static inline int is_dma32(struct zone *zone)
> -{
> -#ifdef CONFIG_ZONE_DMA32
> - return zone == zone->zone_pgdat->node_zones + ZONE_DMA32;
> -#else
> - return 0;
> -#endif
> -}
> -
> -static inline int is_dma(struct zone *zone)
> -{
> -#ifdef CONFIG_ZONE_DMA
> - return zone == zone->zone_pgdat->node_zones + ZONE_DMA;
> -#else
> - return 0;
> -#endif
> -}
> -
> /* These two functions are used to setup the per zone pages min values */
> struct ctl_table;
> int min_free_kbytes_sysctl_handler(struct ctl_table *, int,

huh.

My first inclination is to leave them alone - they cause no harm apart
from a tiny increase in compilation time and they might be used in the
future.

But their names are all quite poor - should be zone_is_normal(), etc.

So yes, let's zap them and hope that if they get resurrected, it will
be with better naming.