2013-06-24 08:27:11

by Dean Jenkins

Subject: SLIP: Is there a maintainer for drivers/net/slip/slip.c ?

Hi,

Using the Linux v3.9 tag, I note that

./scripts/get_maintainer.pl -f drivers/net/slip/slip.c
[email protected] (open list:NETWORKING DRIVERS)
[email protected] (open list)

There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?

I am asking because sl_encaps() and slip_write_wakeup() do not handle
error codes from tty->ops->write() and a recursive stack overflow crash
can occur if the tty->ops->write() fails to write all the characters. I
have some patches to fix this but would like some feedback on an
appropriate solution.

Thanks,

Dean Jenkins
Mentor Graphics

2013-06-24 08:49:57

by Geert Uytterhoeven

Subject: Re: SLIP: Is there a maintainer for drivers/net/slip/slip.c ?

On Mon, Jun 24, 2013 at 10:27 AM, Dean Jenkins <[email protected]> wrote:
> Using the Linux v3.9 tag, I note that
>
> ./scripts/get_maintainer.pl -f drivers/net/slip/slip.c
> [email protected] (open list:NETWORKING DRIVERS)
> [email protected] (open list)
>
> There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?

netdev seems to be the most appropriate mailing list, cfr. what
get_maintainer.pl reported, hence CC netdev added.

> I am asking because sl_encaps() and slip_write_wakeup() do not handle error
> codes from tty->ops->write() and a recursive stack overflow crash can occur
> if the tty->ops->write() fails to write all the characters. I have some
> patches to fix this but would like some feedback on an appropriate solution.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2013-06-24 13:54:01

by Peter Hurley

Subject: Re: SLIP: Is there a maintainer for drivers/net/slip/slip.c ?

On 06/24/2013 04:27 AM, Dean Jenkins wrote:
> Hi,
>
> Using the Linux v3.9 tag, I note that
>
> ./scripts/get_maintainer.pl -f drivers/net/slip/slip.c
> [email protected] (open list:NETWORKING DRIVERS)
> [email protected] (open list)
>
> There seems to be no maintainer for drivers/net/slip/slip.c, is that true ?
>
> I am asking because sl_encaps() and slip_write_wakeup() do not handle error codes from tty->ops->write() and a recursive stack overflow crash can occur if the tty->ops->write() fails to write all the characters. I have some patches to fix this but would like some feedback on an appropriate solution.

SLIP changes would likely go through David Miller <[email protected]>.
TTY changes would go through Greg Kroah-Hartman <[email protected]>

Regards,
Peter Hurley

2013-06-24 14:06:46

by Dean Jenkins

Subject: Re: SLIP: Is there a maintainer for drivers/net/slip/slip.c ?

Hi Peter,

On 24/06/13 14:53, Peter Hurley wrote:
> On 06/24/2013 04:27 AM, Dean Jenkins wrote:
>> Hi,
>>
>> Using the Linux v3.9 tag, I note that
>>
>> ./scripts/get_maintainer.pl -f drivers/net/slip/slip.c
>> [email protected] (open list:NETWORKING DRIVERS)
>> [email protected] (open list)
>>
>> There seems to be no maintainer for drivers/net/slip/slip.c, is that
>> true ?
>>
>> I am asking because sl_encaps() and slip_write_wakeup() do not handle
>> error codes from tty->ops->write() and a recursive stack overflow
>> crash can occur if the tty->ops->write() fails to write all the
>> characters. I have some patches to fix this but would like some
>> feedback on an appropriate solution.
>
> SLIP changes would likely go through David Miller <[email protected]>.
> TTY changes would go through Greg Kroah-Hartman
> <[email protected]>
I have already sent an E-mail to David Miller and the netdev mailing
list but so far got not reply from David.

So I guess I have sent my patches to the correct place ;)

Thanks,

Regards,
Dean Jenkins
Mentor Graphics