2013-06-25 03:30:59

by zhangwei(Jovi)

[permalink] [raw]
Subject: [PATCH 2/2 v3] tracing/uprobes: Support soft-mode disabling

Support soft-mode disabling on uprobe-based dynamic events.
Soft-disabling is just ignoring recording if the soft disabled
flag is set.

Signed-off-by: zhangwei(Jovi) <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Oleg Nesterov <[email protected]>
Cc: Srikar Dronamraju <[email protected]>
---
kernel/trace/trace_uprobe.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
index dbbb4a9..d2da3ea 100644
--- a/kernel/trace/trace_uprobe.c
+++ b/kernel/trace/trace_uprobe.c
@@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,

WARN_ON(call != ftrace_file->event_call);

+ if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
+ return;
+
size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
call->event.type,
--
1.7.9.7


Subject: Re: [PATCH 2/2 v3] tracing/uprobes: Support soft-mode disabling

(2013/06/25 12:30), zhangwei(Jovi) wrote:
> Support soft-mode disabling on uprobe-based dynamic events.
> Soft-disabling is just ignoring recording if the soft disabled
> flag is set.
>
> Signed-off-by: zhangwei(Jovi) <[email protected]>

Reviewed-by: Masami Hiramatsu <[email protected]>

Thank you!

> Cc: Masami Hiramatsu <[email protected]>
> Cc: Frederic Weisbecker <[email protected]>
> Cc: Oleg Nesterov <[email protected]>
> Cc: Srikar Dronamraju <[email protected]>
> ---
> kernel/trace/trace_uprobe.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index dbbb4a9..d2da3ea 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -530,6 +530,9 @@ static void uprobe_trace_print(struct trace_uprobe *tu,
>
> WARN_ON(call != ftrace_file->event_call);
>
> + if (test_bit(FTRACE_EVENT_FL_SOFT_DISABLED_BIT, &ftrace_file->flags))
> + return;
> +
> size = SIZEOF_TRACE_ENTRY(is_ret_probe(tu));
> event = trace_event_buffer_lock_reserve(&buffer, ftrace_file,
> call->event.type,
>


--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: [email protected]