2013-07-03 07:48:33

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the final tree (net-next tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allnoconfig) failed like this:

fs/select.c: In function 'do_select':
fs/select.c:408:2: error: implicit declaration of function 'll_start_time' [-Werror=implicit-function-declaration]
u64 ll_start = ll_start_time(ll_flag);
^
fs/select.c:409:2: error: implicit declaration of function 'll_run_time' [-Werror=implicit-function-declaration]
u64 ll_time = ll_run_time();
^
fs/select.c:504:3: error: too many arguments to function 'can_poll_ll'
if (ll_flag && can_ll && can_poll_ll(ll_start, ll_time))
^
In file included from fs/select.c:31:0:
include/net/ll_poll.h:194:20: note: declared here
static inline bool can_poll_ll(u64 end_time)
^
fs/select.c: In function 'do_poll':
fs/select.c:826:3: error: too many arguments to function 'can_poll_ll'
if (ll_flag && can_ll && can_poll_ll(ll_start, ll_time))
^
In file included from fs/select.c:31:0:
include/net/ll_poll.h:194:20: note: declared here
static inline bool can_poll_ll(u64 end_time)
^

Caused by commit 1bc2774d8664 ("net: convert lls to use time_in_range()")
from the net-next tree.

I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
allnoconfig") out of tomorrow's net-next tree. (I am feeling generous
and noticed that patch being applied :-))

--
Cheers,
Stephen Rothwell [email protected]


Attachments:
(No filename) (1.39 kB)
(No filename) (836.00 B)
Download all attachments

2013-07-03 07:51:17

by Sedat Dilek

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)

On Wed, Jul 3, 2013 at 9:48 AM, Stephen Rothwell <[email protected]> wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
[...]
> Caused by commit 1bc2774d8664 ("net: convert lls to use time_in_range()")
> from the net-next tree.
>
> I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
> allnoconfig") out of tomorrow's net-next tree. (I am feeling generous
> and noticed that patch being applied :-))
>

/me loves generous coders and shy girls.

- Sedat -

> --
> Cheers,
> Stephen Rothwell [email protected]

2013-07-03 08:46:48

by Eliezer Tamir

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)


On 03/07/2013 10:48, Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allnoconfig) failed like this:
>
> fs/select.c: In function 'do_select':
> fs/select.c:408:2: error: implicit declaration of function 'll_start_time' [-Werror=implicit-function-declaration]
> u64 ll_start = ll_start_time(ll_flag);
[..]
> Caused by commit 1bc2774d8664 ("net: convert lls to use time_in_range()")
> from the net-next tree.
>
> I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
> allnoconfig") out of tomorrow's net-next tree. (I am feeling generous
> and noticed that patch being applied :-))

Yes, my bad.
Thank you.

I knew lots of people could get this so I sent out a fix ASAP (at 6AM
my time).

If it's not too much trouble we should add:
Reported-by: kbuild test robot <[email protected]>

-Eliezer

2013-07-03 19:17:16

by David Miller

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (net-next tree related)

From: Stephen Rothwell <[email protected]>
Date: Wed, 3 Jul 2013 17:48:22 +1000

> I cherry-picked the commit 419076f59fc5 ("net: lls fix build with
> allnoconfig") out of tomorrow's net-next tree. (I am feeling generous
> and noticed that patch being applied :-))

Thank you :)