2013-06-28 02:32:38

by Chen Gang

Subject: [PATCH] include/asm-generic/iomap.h: trivial: use '__GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Recommend to let the header file macro mark match the file name.

Signed-off-by: Chen Gang <[email protected]>
---
include/asm-generic/iomap.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h
index 6afd7d6..236c78c 100644
--- a/include/asm-generic/iomap.h
+++ b/include/asm-generic/iomap.h
@@ -1,5 +1,5 @@
-#ifndef __GENERIC_IO_H
-#define __GENERIC_IO_H
+#ifndef __GENERIC_IOMAP_H
+#define __GENERIC_IOMAP_H

#include <linux/linkage.h>
#include <asm/byteorder.h>
@@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)

#include <asm-generic/pci_iomap.h>

-#endif
+#endif /* __GENERIC_IOMAP_H */
--
1.7.7.6

2013-06-28 02:36:00

by Chen Gang

Subject: Re: [PATCH] include/asm-generic/iomap.h: trivial: use '__GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Oh, sorry, need use '__ASM_GENERIC_IOMAP_H, instead.

I will send patch v2.


On 06/28/2013 10:31 AM, Chen Gang wrote:
> Recommend to let the header file macro mark match the file name.
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> include/asm-generic/iomap.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h
> index 6afd7d6..236c78c 100644
> --- a/include/asm-generic/iomap.h
> +++ b/include/asm-generic/iomap.h
> @@ -1,5 +1,5 @@
> -#ifndef __GENERIC_IO_H
> -#define __GENERIC_IO_H
> +#ifndef __GENERIC_IOMAP_H
> +#define __GENERIC_IOMAP_H
>
> #include <linux/linkage.h>
> #include <asm/byteorder.h>
> @@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
>
> #include <asm-generic/pci_iomap.h>
>
> -#endif
> +#endif /* __GENERIC_IOMAP_H */
>


--
Chen Gang

2013-06-28 02:38:16

by Chen Gang

Subject: [PATCH v2] include/asm-generic/iomap.h: trivial: use '__ASM_GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Recommend to let the header file macro mark match the file name.

Signed-off-by: Chen Gang <[email protected]>
---
include/asm-generic/iomap.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h
index 6afd7d6..facfb39 100644
--- a/include/asm-generic/iomap.h
+++ b/include/asm-generic/iomap.h
@@ -1,5 +1,5 @@
-#ifndef __GENERIC_IO_H
-#define __GENERIC_IO_H
+#ifndef __ASM_GENERIC_IOMAP_H
+#define __ASM_GENERIC_IOMAP_H

#include <linux/linkage.h>
#include <asm/byteorder.h>
@@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)

#include <asm-generic/pci_iomap.h>

-#endif
+#endif /* __ASM_GENERIC_IOMAP_H */
--
1.7.7.6

2013-07-05 01:08:47

by Chen Gang F T

Subject: Re: [PATCH v2] include/asm-generic/iomap.h: trivial: use '__ASM_GENERIC_IOMAP_H' instead of '__GENERIC_IO_H'

Hello maintainers:

Please help check this patch whether OK, when you have time.

Thanks.

On 06/28/2013 10:37 AM, Chen Gang wrote:
> Recommend to let the header file macro mark match the file name.
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> include/asm-generic/iomap.h | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/asm-generic/iomap.h b/include/asm-generic/iomap.h
> index 6afd7d6..facfb39 100644
> --- a/include/asm-generic/iomap.h
> +++ b/include/asm-generic/iomap.h
> @@ -1,5 +1,5 @@
> -#ifndef __GENERIC_IO_H
> -#define __GENERIC_IO_H
> +#ifndef __ASM_GENERIC_IOMAP_H
> +#define __ASM_GENERIC_IOMAP_H
>
> #include <linux/linkage.h>
> #include <asm/byteorder.h>
> @@ -78,4 +78,4 @@ static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
>
> #include <asm-generic/pci_iomap.h>
>
> -#endif
> +#endif /* __ASM_GENERIC_IOMAP_H */
>


--
Chen Gang