2013-07-15 15:49:38

by Julien Grall

[permalink] [raw]
Subject: Re: [Xen-devel] [PATCH] xen/control: protect functions with CONFIG_HIBERNATE_CALLBACKS to avoid warning

Forgot the different cc.

On 07/15/2013 04:47 PM, Julien Grall wrote:
> On 07/15/2013 04:27 PM, Konrad Rzeszutek Wilk wrote:
>> On Mon, Jul 15, 2013 at 03:24:35PM +0100, Julien Grall wrote:
>>> If CONFIG_HIBERNATE_CALLBACKS is not set gcc will issue warnings:
>>> drivers/xen/manage.c:46:13: warning: 'xen_hvm_post_suspend' defined but not used [-Wunused-function]
>>> drivers/xen/manage.c:52:13: warning: 'xen_pre_suspend' defined but not used [-Wunused-function]
>>> drivers/xen/manage.c:59:13: warning: 'xen_post_suspend' defined but not used [-Wunused-function]
>>
>> Have you checked the upstream kernel?
>
> My apologies, I forgot to check upstream for this patch.
>