2013-07-10 11:51:37

by Phil Carmody

Subject: [PATCH] smack: fix magic value

5d is ']', 'M' is 4d.

Signed-off-by: Phil Carmody <[email protected]>
---
include/uapi/linux/magic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
index 2944278..5c1d878 100644
--- a/include/uapi/linux/magic.h
+++ b/include/uapi/linux/magic.h
@@ -11,7 +11,7 @@
#define DEBUGFS_MAGIC 0x64626720
#define SECURITYFS_MAGIC 0x73636673
#define SELINUX_MAGIC 0xf97cff8c
-#define SMACK_MAGIC 0x43415d53 /* "SMAC" */
+#define SMACK_MAGIC 0x43414d53 /* "SMAC" */
#define RAMFS_MAGIC 0x858458f6 /* some random number */
#define TMPFS_MAGIC 0x01021994
#define HUGETLBFS_MAGIC 0x958458f6 /* some random number */
--
1.7.9.5

2013-07-21 01:48:21

by Casey Schaufler

Subject: Re: [PATCH] smack: fix magic value

On 7/10/2013 4:51 AM, Phil Carmody wrote:
> 5d is ']', 'M' is 4d.

And spelling was never my strong suit. I don't know of anyone
who depends on this value, but in case someone does the correct
fix is to change the comment, not the constant.

>
> Signed-off-by: Phil Carmody <[email protected]>
> ---
> include/uapi/linux/magic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/magic.h b/include/uapi/linux/magic.h
> index 2944278..5c1d878 100644
> --- a/include/uapi/linux/magic.h
> +++ b/include/uapi/linux/magic.h
> @@ -11,7 +11,7 @@
> #define DEBUGFS_MAGIC 0x64626720
> #define SECURITYFS_MAGIC 0x73636673
> #define SELINUX_MAGIC 0xf97cff8c
> -#define SMACK_MAGIC 0x43415d53 /* "SMAC" */
> +#define SMACK_MAGIC 0x43414d53 /* "SMAC" */
> #define RAMFS_MAGIC 0x858458f6 /* some random number */
> #define TMPFS_MAGIC 0x01021994
> #define HUGETLBFS_MAGIC 0x958458f6 /* some random number */