2013-07-25 03:40:44

by Gu Zheng

Subject: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()

Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
but left the variable "dev" unused, delete it.

Signed-off-by: Gu Zheng <[email protected]>
---
drivers/video/vga16fb.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image

static void vga16fb_destroy(struct fb_info *info)
{
- struct platform_device *dev = container_of(info->device, struct platform_device, dev);
iounmap(info->screen_base);
fb_dealloc_cmap(&info->cmap);
/* XXX unshare VGA regions */
--
1.7.7

2013-07-25 09:58:25

by Geert Uytterhoeven

Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()

On Thu, Jul 25, 2013 at 5:37 AM, Gu Zheng <[email protected]> wrote:
> Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it.

When referring to another commit, please also include the oneline summary of
the commit, to make it easier for people to see what it's about.

E.g. "Commit e21d2170f36602ae2708 ("video: remove unnecessary
platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
but left the variable "dev" unused, delete it."

Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2013-07-25 10:06:11

by Gu Zheng

Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()

On 07/25/2013 05:58 PM, Geert Uytterhoeven wrote:

> On Thu, Jul 25, 2013 at 5:37 AM, Gu Zheng <[email protected]> wrote:
>> Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
>> but left the variable "dev" unused, delete it.
>
> When referring to another commit, please also include the oneline summary of
> the commit, to make it easier for people to see what it's about.

Got it, thanks for your reminder.:)

>
> E.g. "Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it."

This is easier reading. I'll update it.

Regards,
Gu


>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>

2013-07-25 10:20:41

by Luis Henriques

Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy()

Hi,

Gu Zheng <[email protected]> writes:

> Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it.
>
> Signed-off-by: Gu Zheng <[email protected]>
> ---
> drivers/video/vga16fb.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>
> static void vga16fb_destroy(struct fb_info *info)
> {
> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
> iounmap(info->screen_base);
> fb_dealloc_cmap(&info->cmap);
> /* XXX unshare VGA regions */

I'm not sure if this fix isn't already queued as I sent a similar
patch a few days ago:

https://lkml.org/lkml/2013/7/10/524

Cheers,
--
Luis