2013-07-28 16:42:26

by Marco Stornelli

Subject: O_TMPFILE problem

Hi,

I'm doing a couple of test about O_TMPFILE on my fs. I can see that when
the file is closed the blocks allocated are not freed. It happens
because of i_mode, it isn't a regular file nor a directory nor a link. I
added S_IFREG in my implementation of tmpfile callback when I have to
call new_inode() and now it works, but am I missing something here?

Marco

2013-07-29 13:22:39

by Jan Kara

Subject: Re: O_TMPFILE problem

On Sun 28-07-13 18:35:12, Marco Stornelli wrote:
> I'm doing a couple of test about O_TMPFILE on my fs. I can see that
> when the file is closed the blocks allocated are not freed. It
> happens because of i_mode, it isn't a regular file nor a directory
> nor a link. I added S_IFREG in my implementation of tmpfile callback
> when I have to call new_inode() and now it works, but am I missing
> something here?
No, I think you are right. We need to add S_IFREG to the mode we pass to
->tmpfile().

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR