2013-07-31 03:21:16

by Xishi Qiu

Subject: [PATCH] fbdev: fix build warning in vga16fb.c

When building v3.11-rc3, I get the following warning:
...
drivers/video/vga16fb.c: In function ?vga16fb_destroy?:
drivers/video/vga16fb.c:1268: warning: unused variable ?dev?
...

Signed-off-by: Xishi Qiu <[email protected]>
---
drivers/video/vga16fb.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
index 830ded4..2827333 100644
--- a/drivers/video/vga16fb.c
+++ b/drivers/video/vga16fb.c
@@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image

static void vga16fb_destroy(struct fb_info *info)
{
- struct platform_device *dev = container_of(info->device, struct platform_device, dev);
iounmap(info->screen_base);
fb_dealloc_cmap(&info->cmap);
/* XXX unshare VGA regions */
--
1.7.1

2013-07-31 03:32:05

by Gu Zheng

Subject: Re: [PATCH] fbdev: fix build warning in vga16fb.c

Hoho, Tomi has applied the patch from Lius to fix this warning.
And this is the sixth patch to fix the same issue since last week.

Thanks,
Gu


On 07/31/2013 11:21 AM, Xishi Qiu wrote:

> When building v3.11-rc3, I get the following warning:
> ...
> drivers/video/vga16fb.c: In function ?vga16fb_destroy?:
> drivers/video/vga16fb.c:1268: warning: unused variable ?dev?
> ...
>
> Signed-off-by: Xishi Qiu <[email protected]>
> ---
> drivers/video/vga16fb.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c
> index 830ded4..2827333 100644
> --- a/drivers/video/vga16fb.c
> +++ b/drivers/video/vga16fb.c
> @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image
>
> static void vga16fb_destroy(struct fb_info *info)
> {
> - struct platform_device *dev = container_of(info->device, struct platform_device, dev);
> iounmap(info->screen_base);
> fb_dealloc_cmap(&info->cmap);
> /* XXX unshare VGA regions */