2013-06-22 06:50:15

by Chen Gang

[permalink] [raw]
Subject: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.


Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.

So move it from "include/asm/page_mm.h to "include/asm/page.h"

The related make:

make ARCH=m68k randconfig
make ARCH=m68k menuconfig
choose cross compiler
disable MMU support
make ARCH=m68k V=1 EXTRA_CFLAGS=-W

The related error:

security/selinux/hooks.c: In function ?selinux_init?:
security/selinux/hooks.c:5821:21: error: ?VM_DATA_DEFAULT_FLAGS? undeclared (first use in this function)

(the attachment is the related .config file)


Signed-off-by: Chen Gang <[email protected]>
---
arch/m68k/include/asm/page.h | 3 +++
arch/m68k/include/asm/page_mm.h | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
index 7c360da..38b024a 100644
--- a/arch/m68k/include/asm/page.h
+++ b/arch/m68k/include/asm/page.h
@@ -48,6 +48,9 @@ extern unsigned long _ramend;
#include <asm/page_no.h>
#endif

+#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
+ VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
+
#include <asm-generic/getorder.h>

#endif /* _M68K_PAGE_H */
diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
index 89f2014..5029f73 100644
--- a/arch/m68k/include/asm/page_mm.h
+++ b/arch/m68k/include/asm/page_mm.h
@@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)

#endif /* __ASSEMBLY__ */

-#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
- VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
-
#endif /* _M68K_PAGE_MM_H */
--
1.7.7.6


Attachments:
issue_config_m68k (44.52 kB)

2013-06-22 06:57:27

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.


The same .config file, also report the compiling error below:

drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of function ‘iowrite8’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of function ‘iowrite16’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of function ‘iowrite32’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of function ‘ioread8’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of function ‘ioread16’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of function ‘ioread32’ [-Werror=implicit-function-declaration]

Excuse me, I am not quite familiar with the related hardware and m68k,
I guess under m68k architecture, we need not this drivers, is it correct ?

Thanks.


On 06/22/2013 02:49 PM, Chen Gang wrote:
>
> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.
>
> So move it from "include/asm/page_mm.h to "include/asm/page.h"
>
> The related make:
>
> make ARCH=m68k randconfig
> make ARCH=m68k menuconfig
> choose cross compiler
> disable MMU support
> make ARCH=m68k V=1 EXTRA_CFLAGS=-W
>
> The related error:
>
> security/selinux/hooks.c: In function �selinux_init�:
> security/selinux/hooks.c:5821:21: error: �VM_DATA_DEFAULT_FLAGS� undeclared (first use in this function)
>
> (the attachment is the related .config file)
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/m68k/include/asm/page.h | 3 +++
> arch/m68k/include/asm/page_mm.h | 3 ---
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
> index 7c360da..38b024a 100644
> --- a/arch/m68k/include/asm/page.h
> +++ b/arch/m68k/include/asm/page.h
> @@ -48,6 +48,9 @@ extern unsigned long _ramend;
> #include <asm/page_no.h>
> #endif
>
> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
> +
> #include <asm-generic/getorder.h>
>
> #endif /* _M68K_PAGE_H */
> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
> index 89f2014..5029f73 100644
> --- a/arch/m68k/include/asm/page_mm.h
> +++ b/arch/m68k/include/asm/page_mm.h
> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
>
> #endif /* __ASSEMBLY__ */
>
> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
> -
> #endif /* _M68K_PAGE_MM_H */
>


--
Chen Gang

Asianux Corporation

2013-06-29 08:01:19

by Michael Schmitz

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

Hi,

> The same .config file, also report the compiling error below:
>
> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of function ‘iowrite8’ [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of function ‘iowrite16’ [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of function ‘iowrite32’ [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of function ‘ioread8’ [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of function ‘ioread16’ [-Werror=implicit-function-declaration]
> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of function ‘ioread32’ [-Werror=implicit-function-declaration]
>
> Excuse me, I am not quite familiar with the related hardware and m68k,
> I guess under m68k architecture, we need not this drivers, is it correct ?

That would be correct, yes. Perhaps add appropriate dependencies in
drivers/i2c/Kconfig to allow building I2C drivers
only on hardware that supports it?

(Joking - some fallout would be expected when using make randconfig)

Cheers,

Michael


> Thanks.
>
>
> On 06/22/2013 02:49 PM, Chen Gang wrote:
>> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.
>>
>> So move it from "include/asm/page_mm.h to "include/asm/page.h"
>>
>> The related make:
>>
>> make ARCH=m68k randconfig
>> make ARCH=m68k menuconfig
>> choose cross compiler
>> disable MMU support
>> make ARCH=m68k V=1 EXTRA_CFLAGS=-W
>>
>> The related error:
>>
>> security/selinux/hooks.c: In function �selinux_init�:
>> security/selinux/hooks.c:5821:21: error: �VM_DATA_DEFAULT_FLAGS� undeclared (first use in this function)
>>
>> (the attachment is the related .config file)
>>
>>
>> Signed-off-by: Chen Gang <[email protected]>
>> ---
>> arch/m68k/include/asm/page.h | 3 +++
>> arch/m68k/include/asm/page_mm.h | 3 ---
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
>> index 7c360da..38b024a 100644
>> --- a/arch/m68k/include/asm/page.h
>> +++ b/arch/m68k/include/asm/page.h
>> @@ -48,6 +48,9 @@ extern unsigned long _ramend;
>> #include <asm/page_no.h>
>> #endif
>>
>> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
>> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>> +
>> #include <asm-generic/getorder.h>
>>
>> #endif /* _M68K_PAGE_H */
>> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
>> index 89f2014..5029f73 100644
>> --- a/arch/m68k/include/asm/page_mm.h
>> +++ b/arch/m68k/include/asm/page_mm.h
>> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
>>
>> #endif /* __ASSEMBLY__ */
>>
>> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
>> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>> -
>> #endif /* _M68K_PAGE_MM_H */
>>
>

2013-06-29 08:26:07

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

On Sat, Jun 29, 2013 at 10:01 AM, Michael Schmitz <[email protected]> wrote:
>> The same .config file, also report the compiling error below:
>>
>> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of
>> function ‘iowrite8’ [-Werror=implicit-function-declaration]
>> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of
>> function ‘iowrite16’ [-Werror=implicit-function-declaration]
>> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of
>> function ‘iowrite32’ [-Werror=implicit-function-declaration]
>> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of
>> function ‘ioread8’ [-Werror=implicit-function-declaration]
>> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of
>> function ‘ioread16’ [-Werror=implicit-function-declaration]
>> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of
>> function ‘ioread32’ [-Werror=implicit-function-declaration]
>>
>> Excuse me, I am not quite familiar with the related hardware and m68k,
>> I guess under m68k architecture, we need not this drivers, is it correct ?

Until someone synthesizes the OpenCores i2c core together with the
OpenCores 68000 core (they seem to have one), and tries to run uClinux
on it...

> That would be correct, yes. Perhaps add appropriate dependencies in
> drivers/i2c/Kconfig to allow building I2C drivers
> only on hardware that supports it?

We still want it for compile-coverage.

Now, the issue is that m68knommu doesn't implement ioread8() and
friends, so I'm adding the uClinux list.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2013-07-01 02:40:18

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

On 06/29/2013 04:26 PM, Geert Uytterhoeven wrote:
> On Sat, Jun 29, 2013 at 10:01 AM, Michael Schmitz <[email protected]> wrote:
>>> >> The same .config file, also report the compiling error below:
>>> >>
>>> >> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of
>>> >> function ‘iowrite8’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of
>>> >> function ‘iowrite16’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of
>>> >> function ‘iowrite32’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of
>>> >> function ‘ioread8’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of
>>> >> function ‘ioread16’ [-Werror=implicit-function-declaration]
>>> >> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of
>>> >> function ‘ioread32’ [-Werror=implicit-function-declaration]
>>> >>
>>> >> Excuse me, I am not quite familiar with the related hardware and m68k,
>>> >> I guess under m68k architecture, we need not this drivers, is it correct ?
> Until someone synthesizes the OpenCores i2c core together with the
> OpenCores 68000 core (they seem to have one), and tries to run uClinux
> on it...
>

OK, thanks.

>> > That would be correct, yes. Perhaps add appropriate dependencies in
>> > drivers/i2c/Kconfig to allow building I2C drivers
>> > only on hardware that supports it?
> We still want it for compile-coverage.
>
> Now, the issue is that m68knommu doesn't implement ioread8() and
> friends, so I'm adding the uClinux list.

Do you also add it to main tree (e.g next-tree), if not, I recommend to
do add it to main tree.


Thanks.
--
Chen Gang

2013-07-01 02:44:08

by Chen Gang

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

Hello Maintainers:

Please help check the patch whether OK or not, when you have time.

Thanks.

On 06/22/2013 02:49 PM, Chen Gang wrote:
>
> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.
>
> So move it from "include/asm/page_mm.h to "include/asm/page.h"
>
> The related make:
>
> make ARCH=m68k randconfig
> make ARCH=m68k menuconfig
> choose cross compiler
> disable MMU support
> make ARCH=m68k V=1 EXTRA_CFLAGS=-W
>
> The related error:
>
> security/selinux/hooks.c: In function ‘selinux_init’:
> security/selinux/hooks.c:5821:21: error: ‘VM_DATA_DEFAULT_FLAGS’ undeclared (first use in this function)
>
> (the attachment is the related .config file)
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/m68k/include/asm/page.h | 3 +++
> arch/m68k/include/asm/page_mm.h | 3 ---
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
> index 7c360da..38b024a 100644
> --- a/arch/m68k/include/asm/page.h
> +++ b/arch/m68k/include/asm/page.h
> @@ -48,6 +48,9 @@ extern unsigned long _ramend;
> #include <asm/page_no.h>
> #endif
>
> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
> +
> #include <asm-generic/getorder.h>
>
> #endif /* _M68K_PAGE_H */
> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
> index 89f2014..5029f73 100644
> --- a/arch/m68k/include/asm/page_mm.h
> +++ b/arch/m68k/include/asm/page_mm.h
> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
>
> #endif /* __ASSEMBLY__ */
>
> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
> -
> #endif /* _M68K_PAGE_MM_H */
>


--
Chen Gang

2013-08-05 01:02:14

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

Hi Geert,

On 29/06/13 18:26, Geert Uytterhoeven wrote:
> On Sat, Jun 29, 2013 at 10:01 AM, Michael Schmitz <[email protected]> wrote:
>>> The same .config file, also report the compiling error below:
>>>
>>> drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of
>>> function ‘iowrite8’ [-Werror=implicit-function-declaration]
>>> drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of
>>> function ‘iowrite16’ [-Werror=implicit-function-declaration]
>>> drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of
>>> function ‘iowrite32’ [-Werror=implicit-function-declaration]
>>> drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of
>>> function ‘ioread8’ [-Werror=implicit-function-declaration]
>>> drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of
>>> function ‘ioread16’ [-Werror=implicit-function-declaration]
>>> drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of
>>> function ‘ioread32’ [-Werror=implicit-function-declaration]
>>>
>>> Excuse me, I am not quite familiar with the related hardware and m68k,
>>> I guess under m68k architecture, we need not this drivers, is it correct ?
>
> Until someone synthesizes the OpenCores i2c core together with the
> OpenCores 68000 core (they seem to have one), and tries to run uClinux
> on it...
>
>> That would be correct, yes. Perhaps add appropriate dependencies in
>> drivers/i2c/Kconfig to allow building I2C drivers
>> only on hardware that supports it?
>
> We still want it for compile-coverage.
>
> Now, the issue is that m68knommu doesn't implement ioread8() and
> friends, so I'm adding the uClinux list.

I think this is relatively strait forward to fix. And we end up
making m68knommu targets consistent with the MMU m68k targets in
the process.

Regards
Greg



[PATCH] m68knommu: user generic iomap to support ioread*/iowrite*

There is no reason we cannot use the generic iomap support to give us
the ioread* and iowrite* family of IO access functions. The m68k arch with
MMU enabled does, so this makes us consistent for all m68k now.

Some potentially valid drivers will fail to compile without these,
for example:

drivers/i2c/busses/i2c-ocores.c:81:2: error: implicit declaration of
function ‘iowrite8’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:86:2: error: implicit declaration of
function ‘iowrite16’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:91:2: error: implicit declaration of
function ‘iowrite32’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:96:2: error: implicit declaration of
function ‘ioread8’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:101:2: error: implicit declaration of
function ‘ioread16’ [-Werror=implicit-function-declaration]
drivers/i2c/busses/i2c-ocores.c:106:2: error: implicit declaration of
function ‘ioread32’ [-Werror=implicit-function-declaration]

Signed-off-by: Greg Ungerer <[email protected]>
---
arch/m68k/Kconfig | 2 +-
arch/m68k/include/asm/io_no.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig
index 821170e..c3cda41 100644
--- a/arch/m68k/Kconfig
+++ b/arch/m68k/Kconfig
@@ -11,6 +11,7 @@ config M68K
select VIRT_TO_BUS
select ARCH_HAVE_NMI_SAFE_CMPXCHG if RMW_INSNS
select GENERIC_CPU_DEVICES
+ select GENERIC_IOMAP
select GENERIC_STRNCPY_FROM_USER if MMU
select GENERIC_STRNLEN_USER if MMU
select FPU if MMU
@@ -72,7 +73,6 @@ source "kernel/Kconfig.freezer"
config MMU
bool "MMU-based Paged Memory Management Support"
default y
- select GENERIC_IOMAP
help
Select if you want MMU-based virtualised addressing space
support by paged memory management. If unsure, say 'Y'.
diff --git a/arch/m68k/include/asm/io_no.h b/arch/m68k/include/asm/io_no.h
index 353bf75..e153478 100644
--- a/arch/m68k/include/asm/io_no.h
+++ b/arch/m68k/include/asm/io_no.h
@@ -4,6 +4,7 @@
#ifdef __KERNEL__

#include <asm/virtconvert.h>
+#include <asm-generic/iomap.h>

/*
* These are for ISA/PCI shared memory _only_ and should never be used

2013-08-05 01:40:33

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

Hi Chen Gang,

On 01/07/13 12:43, Chen Gang wrote:
> Hello Maintainers:
>
> Please help check the patch whether OK or not, when you have time.
>
> Thanks.
>
> On 06/22/2013 02:49 PM, Chen Gang wrote:
>>
>> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.
>>
>> So move it from "include/asm/page_mm.h to "include/asm/page.h"
>>
>> The related make:
>>
>> make ARCH=m68k randconfig
>> make ARCH=m68k menuconfig
>> choose cross compiler
>> disable MMU support
>> make ARCH=m68k V=1 EXTRA_CFLAGS=-W
>>
>> The related error:
>>
>> security/selinux/hooks.c: In function ‘selinux_init’:
>> security/selinux/hooks.c:5821:21: error: ‘VM_DATA_DEFAULT_FLAGS’ undeclared (first use in this function)
>>
>> (the attachment is the related .config file)
>>
>>
>> Signed-off-by: Chen Gang <[email protected]>

I am fine with this:

Acked-by: Greg Ungerer <[email protected]>

Do you want me to add this to the m68knommu git tree, and push to
Linus?

Regards
Greg


>> ---
>> arch/m68k/include/asm/page.h | 3 +++
>> arch/m68k/include/asm/page_mm.h | 3 ---
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
>> index 7c360da..38b024a 100644
>> --- a/arch/m68k/include/asm/page.h
>> +++ b/arch/m68k/include/asm/page.h
>> @@ -48,6 +48,9 @@ extern unsigned long _ramend;
>> #include <asm/page_no.h>
>> #endif
>>
>> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
>> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>> +
>> #include <asm-generic/getorder.h>
>>
>> #endif /* _M68K_PAGE_H */
>> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
>> index 89f2014..5029f73 100644
>> --- a/arch/m68k/include/asm/page_mm.h
>> +++ b/arch/m68k/include/asm/page_mm.h
>> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
>>
>> #endif /* __ASSEMBLY__ */
>>
>> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
>> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>> -
>> #endif /* _M68K_PAGE_MM_H */
>>
>
>

2013-08-05 02:22:34

by Chen Gang F T

[permalink] [raw]
Subject: Re: [PATCH] arch: m68k: include: asm: define 'VM_DATA_DEFAULT_FLAGS' no matter whether has 'NOMMU' or not.

On 08/05/2013 09:37 AM, Greg Ungerer wrote:
> Hi Chen Gang,
>
> On 01/07/13 12:43, Chen Gang wrote:
>> Hello Maintainers:
>>
>> Please help check the patch whether OK or not, when you have time.
>>
>> Thanks.
>>
>> On 06/22/2013 02:49 PM, Chen Gang wrote:
>>>
>>> Define 'VM_DATA_DEFAULT_FLAGS' when 'NOMMU' to pass compiling.
>>>
>>> So move it from "include/asm/page_mm.h to "include/asm/page.h"
>>>
>>> The related make:
>>>
>>> make ARCH=m68k randconfig
>>> make ARCH=m68k menuconfig
>>> choose cross compiler
>>> disable MMU support
>>> make ARCH=m68k V=1 EXTRA_CFLAGS=-W
>>>
>>> The related error:
>>>
>>> security/selinux/hooks.c: In function ‘selinux_init’:
>>> security/selinux/hooks.c:5821:21: error: ‘VM_DATA_DEFAULT_FLAGS’ undeclared (first use in this function)
>>>
>>> (the attachment is the related .config file)
>>>
>>>
>>> Signed-off-by: Chen Gang <[email protected]>
>
> I am fine with this:
>
> Acked-by: Greg Ungerer <[email protected]>
>

Thank you very much.

> Do you want me to add this to the m68knommu git tree, and push to
> Linus?
>

Yeah, thank you.

:-)

> Regards
> Greg
>
>
>>> ---
>>> arch/m68k/include/asm/page.h | 3 +++
>>> arch/m68k/include/asm/page_mm.h | 3 ---
>>> 2 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/m68k/include/asm/page.h b/arch/m68k/include/asm/page.h
>>> index 7c360da..38b024a 100644
>>> --- a/arch/m68k/include/asm/page.h
>>> +++ b/arch/m68k/include/asm/page.h
>>> @@ -48,6 +48,9 @@ extern unsigned long _ramend;
>>> #include <asm/page_no.h>
>>> #endif
>>>
>>> +#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
>>> + VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>>> +
>>> #include <asm-generic/getorder.h>
>>>
>>> #endif /* _M68K_PAGE_H */
>>> diff --git a/arch/m68k/include/asm/page_mm.h b/arch/m68k/include/asm/page_mm.h
>>> index 89f2014..5029f73 100644
>>> --- a/arch/m68k/include/asm/page_mm.h
>>> +++ b/arch/m68k/include/asm/page_mm.h
>>> @@ -173,7 +173,4 @@ static inline __attribute_const__ int __virt_to_node_shift(void)
>>>
>>> #endif /* __ASSEMBLY__ */
>>>
>>> -#define VM_DATA_DEFAULT_FLAGS (VM_READ | VM_WRITE | VM_EXEC | \
>>> - VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC)
>>> -
>>> #endif /* _M68K_PAGE_MM_H */
>>>
>>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


--
Chen Gang