2021-08-24 07:50:41

by teng sterling

[permalink] [raw]
Subject: Re: [PATCH v2] docs/zh_CN: Add zh_CN/admin-guide/sysrq.rst

Junhua Huang <[email protected]> 于2021年8月22日周日 下午10:33写道:
>
> From: Junhua Huang <[email protected]>
>
> Add translation zh_CN/admin-guide/sysrq.rst and link it to
> zh_CN/admin-guide/index.rst while clean its todo entry.
>
> Reviewed-by: Yanteng Si <[email protected]>
> Signed-off-by: Junhua Huang <[email protected]>
Hi Junhua:

Some warnings were generated during the build process, if you can fix them:

Reviewed-by: Yanteng Si <[email protected]>

BTW:

* It is best not to pick the Reviewed-by tag until the reviewer
voluntarily signs it.

* Perform adequate testing before send patches.
build it, --------> fix error and warning.
checkpatch.pl <your patch>, ---------> fix error and warning.
> ---

Thanks,

Yanteng


2021-08-25 16:02:55

by 黄军华

[permalink] [raw]
Subject: Re:Re: [PATCH v2] docs/zh_CN: Add zh_CN/admin-guide/sysrq.rst


Hi??Yanteng

Thank you for pointing my problems. I will fix it in v3.


?? 2021-08-24 15:48:00??"teng sterling" <[email protected]> д????
>Junhua Huang <[email protected]> ??2021??8??22?????? ????10:33д????
>>
>> From: Junhua Huang <[email protected]>
>>
>> Add translation zh_CN/admin-guide/sysrq.rst and link it to
>> zh_CN/admin-guide/index.rst while clean its todo entry.
>>
>> Reviewed-by: Yanteng Si <[email protected]>
>> Signed-off-by: Junhua Huang <[email protected]>
>Hi Junhua:
>
>Some warnings were generated during the build process, if you can fix them:
OK, I will fix them.
>
>Reviewed-by: Yanteng Si <[email protected]>
>
>BTW:
>
>* It is best not to pick the Reviewed-by tag until the reviewer
>voluntarily signs it.
my misunderstanding for it.
>
>* Perform adequate testing before send patches.
> build it, --------> fix error and warning.
> checkpatch.pl <your patch>, ---------> fix error and warning.
>> ---
>
>Thanks,
>
>Yanteng

Thanks,

Junhua