2019-11-11 14:47:40

by Jan Beulich

Subject: [PATCH 0/3] xen/mcelog: assorted adjustments

The 1st change is simple cleanup, noticed while preparing for the
2nd patch, which presents the consumer of the interface extension
proposed in
https://lists.xenproject.org/archives/html/xen-devel/2019-11/msg00377.html.
The 3rd patch is sort of optional, considering that 32-bit Xen
support is slated to be phased out of the kernel.

1: drop __MC_MSR_MCGCAP
2: add PPIN to record when available
3: also allow building for 32-bit kernels

Jan

2019-11-11 14:47:49

by Jan Beulich

Subject: [PATCH 3/3] xen/mcelog: also allow building for 32-bit kernels

There's no apparent reason why it can be used on 64-bit only.

Signed-off-by: Jan Beulich <[email protected]>

--- a/drivers/xen/Kconfig
+++ b/drivers/xen/Kconfig
@@ -285,7 +285,7 @@ config XEN_ACPI_PROCESSOR

config XEN_MCE_LOG
bool "Xen platform mcelog"
- depends on XEN_DOM0 && X86_64 && X86_MCE
+ depends on XEN_DOM0 && X86 && X86_MCE
help
Allow kernel fetching MCE error from Xen platform and
converting it into Linux mcelog format for mcelog tools

2019-11-13 00:18:53

by Boris Ostrovsky

Subject: Re: [PATCH 3/3] xen/mcelog: also allow building for 32-bit kernels

On 11/11/19 9:46 AM, Jan Beulich wrote:
> There's no apparent reason why it can be used on 64-bit only.
>
> Signed-off-by: Jan Beulich <[email protected]>
>
> --- a/drivers/xen/Kconfig
> +++ b/drivers/xen/Kconfig
> @@ -285,7 +285,7 @@ config XEN_ACPI_PROCESSOR
>
> config XEN_MCE_LOG
> bool "Xen platform mcelog"
> - depends on XEN_DOM0 && X86_64 && X86_MCE
> + depends on XEN_DOM0 && X86 && X86_MCE

Can we have X86_MCE without X86?

-boris

> help
> Allow kernel fetching MCE error from Xen platform and
> converting it into Linux mcelog format for mcelog tools
>

2019-11-13 13:48:17

by Jan Beulich

Subject: Re: [Xen-devel] [PATCH 3/3] xen/mcelog: also allow building for 32-bit kernels

On 13.11.2019 01:15, Boris Ostrovsky wrote:
> On 11/11/19 9:46 AM, Jan Beulich wrote:
>> There's no apparent reason why it can be used on 64-bit only.
>>
>> Signed-off-by: Jan Beulich <[email protected]>
>>
>> --- a/drivers/xen/Kconfig
>> +++ b/drivers/xen/Kconfig
>> @@ -285,7 +285,7 @@ config XEN_ACPI_PROCESSOR
>>
>> config XEN_MCE_LOG
>> bool "Xen platform mcelog"
>> - depends on XEN_DOM0 && X86_64 && X86_MCE
>> + depends on XEN_DOM0 && X86 && X86_MCE
>
> Can we have X86_MCE without X86?

I don't think we can. Is this a request to drop the middle
operand altogether?

Jan

2019-11-13 14:10:48

by Jürgen Groß

Subject: Re: [Xen-devel] [PATCH 3/3] xen/mcelog: also allow building for 32-bit kernels

On 13.11.19 14:47, Jan Beulich wrote:
> On 13.11.2019 01:15, Boris Ostrovsky wrote:
>> On 11/11/19 9:46 AM, Jan Beulich wrote:
>>> There's no apparent reason why it can be used on 64-bit only.
>>>
>>> Signed-off-by: Jan Beulich <[email protected]>
>>>
>>> --- a/drivers/xen/Kconfig
>>> +++ b/drivers/xen/Kconfig
>>> @@ -285,7 +285,7 @@ config XEN_ACPI_PROCESSOR
>>>
>>> config XEN_MCE_LOG
>>> bool "Xen platform mcelog"
>>> - depends on XEN_DOM0 && X86_64 && X86_MCE
>>> + depends on XEN_DOM0 && X86 && X86_MCE
>>
>> Can we have X86_MCE without X86?
>
> I don't think we can. Is this a request to drop the middle
> operand altogether?

I think this would be reasonable. X86_64 was an additional dependency,
while X86 isn't.

With the X86 removed:

Reviewed-by: Juergen Gross <[email protected]>


Juergen

2019-11-14 07:56:41

by Jürgen Groß

Subject: Re: [Xen-devel] [PATCH 3/3] xen/mcelog: also allow building for 32-bit kernels

On 13.11.19 14:47, Jan Beulich wrote:
> On 13.11.2019 01:15, Boris Ostrovsky wrote:
>> On 11/11/19 9:46 AM, Jan Beulich wrote:
>>> There's no apparent reason why it can be used on 64-bit only.
>>>
>>> Signed-off-by: Jan Beulich <[email protected]>
>>>
>>> --- a/drivers/xen/Kconfig
>>> +++ b/drivers/xen/Kconfig
>>> @@ -285,7 +285,7 @@ config XEN_ACPI_PROCESSOR
>>>
>>> config XEN_MCE_LOG
>>> bool "Xen platform mcelog"
>>> - depends on XEN_DOM0 && X86_64 && X86_MCE
>>> + depends on XEN_DOM0 && X86 && X86_MCE
>>
>> Can we have X86_MCE without X86?
>
> I don't think we can. Is this a request to drop the middle
> operand altogether?

No need to resend the series. I can make this change while committing.


Juergen

2019-11-14 13:07:03

by Jürgen Groß

Subject: Re: [PATCH 0/3] xen/mcelog: assorted adjustments

On 11.11.19 15:43, Jan Beulich wrote:
> The 1st change is simple cleanup, noticed while preparing for the
> 2nd patch, which presents the consumer of the interface extension
> proposed in
> https://lists.xenproject.org/archives/html/xen-devel/2019-11/msg00377.html.
> The 3rd patch is sort of optional, considering that 32-bit Xen
> support is slated to be phased out of the kernel.
>
> 1: drop __MC_MSR_MCGCAP
> 2: add PPIN to record when available
> 3: also allow building for 32-bit kernels

Pushed the series to xen/tip.git for-linus-5.5a


Juergen