In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
driver was removed, along with the Kconfig entry, but the Makefile line
in drivers/staging/Makefile was not updated, so things like 'make clean'
fail to work properly as they will decend into all subdirectories to try
to clean things up.
Resolve this by removing the entry in the main staging Makefile.
Reported-by: Thorsten Leemhuis <[email protected]>
Cc: Philipp Hortmann <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
drivers/staging/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index ffa70dda481d..0f6379436443 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -4,7 +4,6 @@
obj-y += media/
obj-$(CONFIG_PRISM2_USB) += wlan-ng/
obj-$(CONFIG_FB_OLPC_DCON) += olpc_dcon/
-obj-$(CONFIG_RTL8192U) += rtl8192u/
obj-$(CONFIG_RTL8192E) += rtl8192e/
obj-$(CONFIG_RTL8723BS) += rtl8723bs/
obj-$(CONFIG_R8712U) += rtl8712/
--
2.42.0
On 17.10.23 10:13, Greg Kroah-Hartman wrote:
> In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
> driver was removed, along with the Kconfig entry, but the Makefile line
> in drivers/staging/Makefile was not updated, so things like 'make clean'
> fail to work properly as they will decend into all subdirectories to try
> to clean things up.
>
> Resolve this by removing the entry in the main staging Makefile.
>
> Reported-by: Thorsten Leemhuis <[email protected]>
> Cc: Philipp Hortmann <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Thx Greg, that fixed things for my case. In case anyone cares:
Tested-by: Thorsten Leemhuis <[email protected]>
Ciao, Thorsten
On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote:
> On 17.10.23 10:13, Greg Kroah-Hartman wrote:
> > In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
> > driver was removed, along with the Kconfig entry, but the Makefile line
> > in drivers/staging/Makefile was not updated, so things like 'make clean'
> > fail to work properly as they will decend into all subdirectories to try
> > to clean things up.
> >
> > Resolve this by removing the entry in the main staging Makefile.
> >
> > Reported-by: Thorsten Leemhuis <[email protected]>
> > Cc: Philipp Hortmann <[email protected]>
> > Cc: Arnd Bergmann <[email protected]>
> > Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
> > Signed-off-by: Greg Kroah-Hartman <[email protected]>
>
> Thx Greg, that fixed things for my case. In case anyone cares:
I care, thanks!
On 10/17/23 15:35, Greg Kroah-Hartman wrote:
> On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote:
>> On 17.10.23 10:13, Greg Kroah-Hartman wrote:
>>> In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
>>> driver was removed, along with the Kconfig entry, but the Makefile line
>>> in drivers/staging/Makefile was not updated, so things like 'make clean'
>>> fail to work properly as they will decend into all subdirectories to try
>>> to clean things up.
>>>
>>> Resolve this by removing the entry in the main staging Makefile.
>>>
>>> Reported-by: Thorsten Leemhuis <[email protected]>
>>> Cc: Philipp Hortmann <[email protected]>
>>> Cc: Arnd Bergmann <[email protected]>
>>> Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
>>> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>>
>> Thx Greg, that fixed things for my case. In case anyone cares:
>
> I care, thanks!
Sorry for messing up. I did a compile test of the entire kernel but I
was not aware that I also need to test 'make clean'
Bye Philipp
On Tue, Oct 17, 2023 at 08:07:33PM +0200, Philipp Hortmann wrote:
> On 10/17/23 15:35, Greg Kroah-Hartman wrote:
> > On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote:
> > > On 17.10.23 10:13, Greg Kroah-Hartman wrote:
> > > > In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
> > > > driver was removed, along with the Kconfig entry, but the Makefile line
> > > > in drivers/staging/Makefile was not updated, so things like 'make clean'
> > > > fail to work properly as they will decend into all subdirectories to try
> > > > to clean things up.
> > > >
> > > > Resolve this by removing the entry in the main staging Makefile.
> > > >
> > > > Reported-by: Thorsten Leemhuis <[email protected]>
> > > > Cc: Philipp Hortmann <[email protected]>
> > > > Cc: Arnd Bergmann <[email protected]>
> > > > Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
> > > > Signed-off-by: Greg Kroah-Hartman <[email protected]>
> > >
> > > Thx Greg, that fixed things for my case. In case anyone cares:
> >
> > I care, thanks!
>
>
> Sorry for messing up. I did a compile test of the entire kernel but I was
> not aware that I also need to test 'make clean'
Not a problem, I didn't either, and neither did the 0-day bot.
greg k-h