2013-08-06 08:36:24

by Xishi Qiu

Subject: [PATCH V2] kexec: remove unnecessary return

Code can not run here forever, so remove the unnecessary return.

Signed-off-by: Xishi Qiu <[email protected]>
Suggested-by: Zhang Yanfei <[email protected]>
---
kernel/kexec.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/kernel/kexec.c b/kernel/kexec.c
index 59f7b55..2a74f30 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
if (first_colon && (!first_space || first_colon < first_space))
return parse_crashkernel_mem(ck_cmdline, system_ram,
crash_size, crash_base);
- else
- return parse_crashkernel_simple(ck_cmdline, crash_size,
- crash_base);

- return 0;
+ return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
}

/*
--
1.7.1

2013-08-06 08:39:22

by Simon Horman

Subject: Re: [PATCH V2] kexec: remove unnecessary return

On Tue, Aug 06, 2013 at 04:35:00PM +0800, Xishi Qiu wrote:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <[email protected]>
> Suggested-by: Zhang Yanfei <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

> ---
> kernel/kexec.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..2a74f30 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
> if (first_colon && (!first_space || first_colon < first_space))
> return parse_crashkernel_mem(ck_cmdline, system_ram,
> crash_size, crash_base);
> - else
> - return parse_crashkernel_simple(ck_cmdline, crash_size,
> - crash_base);
>
> - return 0;
> + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
> }
>
> /*
> --
> 1.7.1
>
>
> _______________________________________________
> kexec mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/kexec
>

2013-08-06 08:44:19

by Zhang Yanfei

Subject: Re: [PATCH V2] kexec: remove unnecessary return

于 2013/8/6 16:35, Xishi Qiu 写道:
> Code can not run here forever, so remove the unnecessary return.
>
> Signed-off-by: Xishi Qiu <[email protected]>
> Suggested-by: Zhang Yanfei <[email protected]>

Reviewed-by: Zhang Yanfei <[email protected]>

> ---
> kernel/kexec.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 59f7b55..2a74f30 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -1474,11 +1474,8 @@ static int __init __parse_crashkernel(char *cmdline,
> if (first_colon && (!first_space || first_colon < first_space))
> return parse_crashkernel_mem(ck_cmdline, system_ram,
> crash_size, crash_base);
> - else
> - return parse_crashkernel_simple(ck_cmdline, crash_size,
> - crash_base);
>
> - return 0;
> + return parse_crashkernel_simple(ck_cmdline, crash_size, crash_base);
> }
>
> /*
>


--
Thanks.
Zhang Yanfei