This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
Fixed to adjust totalhigh_pages when hot-removing memory by commit
3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
duplicated decreasing of totalhigh_pages.
Signed-off-by: Joonyoung Shim <[email protected]>
---
The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
is it right?
mm/page_alloc.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index b100255..2b28216 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
list_del(&page->lru);
rmv_page_order(page);
zone->free_area[order].nr_free--;
-#ifdef CONFIG_HIGHMEM
- if (PageHighMem(page))
- totalhigh_pages -= 1 << order;
-#endif
for (i = 0; i < (1 << order); i++)
SetPageReserved((page+i));
pfn += (1 << order);
--
1.8.1.2
Hi,
On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
> This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
Could you please also include commit descriptions, i.e.
commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
lowmem count overflow when offline pages")?
> Fixed to adjust totalhigh_pages when hot-removing memory by commit
> 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
> duplicated decreasing of totalhigh_pages.
Could you please describe it a bit more (because it is non-obvious) how
the commit cea27eb effectively does the same totalhigh_pages adjustment
that is present in the commit 3dcc057?
> Signed-off-by: Joonyoung Shim <[email protected]>
> ---
> The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
> is it right?
It is in Linus' tree now but you're probably right that it should be
limited to stable tree.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> mm/page_alloc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index b100255..2b28216 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> list_del(&page->lru);
> rmv_page_order(page);
> zone->free_area[order].nr_free--;
> -#ifdef CONFIG_HIGHMEM
> - if (PageHighMem(page))
> - totalhigh_pages -= 1 << order;
> -#endif
> for (i = 0; i < (1 << order); i++)
> SetPageReserved((page+i));
> pfn += (1 << order);
On Wednesday, July 31, 2013 01:17:46 PM Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
> > This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>
> Could you please also include commit descriptions, i.e.
> commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
> lowmem count overflow when offline pages")?
>
> > Fixed to adjust totalhigh_pages when hot-removing memory by commit
> > 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
> > duplicated decreasing of totalhigh_pages.
>
> Could you please describe it a bit more (because it is non-obvious) how
> the commit cea27eb effectively does the same totalhigh_pages adjustment
> that is present in the commit 3dcc057?
Err, the other way around. How the commit 3dcc057 ("mm: correctly update
zone->managed_pages") does what cea27eb ("mm/memory-hotplug: fix lowmem
count overflow when offline pages") did.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> > Signed-off-by: Joonyoung Shim <[email protected]>
> > ---
> > The commit cea27eb2a202959783f81254c48c250ddd80e129 is only for stable,
> > is it right?
>
> It is in Linus' tree now but you're probably right that it should be
> limited to stable tree.
>
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
>
> > mm/page_alloc.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> > index b100255..2b28216 100644
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -6274,10 +6274,6 @@ __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn)
> > list_del(&page->lru);
> > rmv_page_order(page);
> > zone->free_area[order].nr_free--;
> > -#ifdef CONFIG_HIGHMEM
> > - if (PageHighMem(page))
> > - totalhigh_pages -= 1 << order;
> > -#endif
> > for (i = 0; i < (1 << order); i++)
> > SetPageReserved((page+i));
> > pfn += (1 << order);
On 07/31/2013 08:48 PM, Bartlomiej Zolnierkiewicz wrote:
> On Wednesday, July 31, 2013 01:17:46 PM Bartlomiej Zolnierkiewicz wrote:
>> Hi,
>>
>> On Wednesday, July 31, 2013 05:50:02 PM Joonyoung Shim wrote:
>>> This reverts commit cea27eb2a202959783f81254c48c250ddd80e129.
>> Could you please also include commit descriptions, i.e.
>> commit cea27eb2a202959783f81254c48c250ddd80e129 ("mm/memory-hotplug: fix
>> lowmem count overflow when offline pages")?
>>
>>> Fixed to adjust totalhigh_pages when hot-removing memory by commit
>>> 3dcc0571cd64816309765b7c7e4691a4cadf2ee7, so that commit occurs
>>> duplicated decreasing of totalhigh_pages.
>> Could you please describe it a bit more (because it is non-obvious) how
>> the commit cea27eb effectively does the same totalhigh_pages adjustment
>> that is present in the commit 3dcc057?
> Err, the other way around. How the commit 3dcc057 ("mm: correctly update
> zone->managed_pages") does what cea27eb ("mm/memory-hotplug: fix lowmem
> count overflow when offline pages") did.
>
OK, i updated to patch v2.
Thanks.