2013-08-09 18:26:19

by Kumar Gaurav

Subject: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED

Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
of more than 80 chars on single line by sliting the line in two.

Signed-off-by: Kumar Gaurav <[email protected]>
---
drivers/net/ethernet/lantiq_etop.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index bfdb0686..04c3a82 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -282,7 +282,7 @@ ltq_etop_hw_init(struct net_device *dev)

if (IS_TX(i)) {
ltq_dma_alloc_tx(&ch->dma);
- request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
+ request_irq(irq, ltq_etop_dma_irq, 0,
"etop_tx", priv);
} else if (IS_RX(i)) {
ltq_dma_alloc_rx(&ch->dma);
@@ -291,7 +291,7 @@ ltq_etop_hw_init(struct net_device *dev)
if (ltq_etop_alloc_skb(ch))
return -ENOMEM;
ch->dma.desc = 0;
- request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
+ request_irq(irq, ltq_etop_dma_irq, 0,
"etop_rx", priv);
}
ch->dma.irq = irq;
@@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
if (err)
goto err_netdev;

- /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
+ /* Set addr_assign_type here,
+ *ltq_etop_set_mac_address would reset it.
+ */
if (random_mac)
dev->addr_assign_type = NET_ADDR_RANDOM;

--
1.7.9.5

2013-08-09 18:31:55

by Kumar Gaurav

Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED

It's a single patch. Please don't be confused with the subject [PATCH
17/17]. I forgot to edit this before sending.
my apology for mistake

On Friday 09 August 2013 11:55 PM, Kumar Gaurav wrote:
> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
> of more than 80 chars on single line by sliting the line in two.
>
> Signed-off-by: Kumar Gaurav <[email protected]>
> ---
> drivers/net/ethernet/lantiq_etop.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index bfdb0686..04c3a82 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
> @@ -282,7 +282,7 @@ ltq_etop_hw_init(struct net_device *dev)
>
> if (IS_TX(i)) {
> ltq_dma_alloc_tx(&ch->dma);
> - request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
> + request_irq(irq, ltq_etop_dma_irq, 0,
> "etop_tx", priv);
> } else if (IS_RX(i)) {
> ltq_dma_alloc_rx(&ch->dma);
> @@ -291,7 +291,7 @@ ltq_etop_hw_init(struct net_device *dev)
> if (ltq_etop_alloc_skb(ch))
> return -ENOMEM;
> ch->dma.desc = 0;
> - request_irq(irq, ltq_etop_dma_irq, IRQF_DISABLED,
> + request_irq(irq, ltq_etop_dma_irq, 0,
> "etop_rx", priv);
> }
> ch->dma.irq = irq;
> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
> if (err)
> goto err_netdev;
>
> - /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
> + /* Set addr_assign_type here,
> + *ltq_etop_set_mac_address would reset it.
> + */
> if (random_mac)
> dev->addr_assign_type = NET_ADDR_RANDOM;
>

2013-08-09 19:38:09

by Sergei Shtylyov

Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED

Hello.

On 08/09/2013 10:25 PM, Kumar Gaurav wrote:

> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
> of more than 80 chars on single line by sliting the line in two.

That's clearly a material for 2 separate patches.

> Signed-off-by: Kumar Gaurav <[email protected]>
> ---
> drivers/net/ethernet/lantiq_etop.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
> index bfdb0686..04c3a82 100644
> --- a/drivers/net/ethernet/lantiq_etop.c
> +++ b/drivers/net/ethernet/lantiq_etop.c
[...]
> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
> if (err)
> goto err_netdev;
>
> - /* Set addr_assign_type here, ltq_etop_set_mac_address would reset it. */
> + /* Set addr_assign_type here,
> + *ltq_etop_set_mac_address would reset it.

You forgot space after * here.

WBR, Sergei

2013-08-09 20:00:23

by Kumar Gaurav

Subject: Re: [PATCH 17/17] net:ethernet:lantiq_etop.c: Removed deprecated IRQF_DISABLED

On Saturday 10 August 2013 01:08 AM, Sergei Shtylyov wrote:
> Hello.
>
> On 08/09/2013 10:25 PM, Kumar Gaurav wrote:
>
>> Removed IRQF_DISABLED as it is deprecated and fixed a coding style issue
>> of more than 80 chars on single line by sliting the line in two.
>
> That's clearly a material for 2 separate patches.
>
>> Signed-off-by: Kumar Gaurav <[email protected]>
>> ---
>> drivers/net/ethernet/lantiq_etop.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/net/ethernet/lantiq_etop.c
>> b/drivers/net/ethernet/lantiq_etop.c
>> index bfdb0686..04c3a82 100644
>> --- a/drivers/net/ethernet/lantiq_etop.c
>> +++ b/drivers/net/ethernet/lantiq_etop.c
> [...]
>> @@ -653,7 +653,9 @@ ltq_etop_init(struct net_device *dev)
>> if (err)
>> goto err_netdev;
>>
>> - /* Set addr_assign_type here, ltq_etop_set_mac_address would
>> reset it. */
>> + /* Set addr_assign_type here,
>> + *ltq_etop_set_mac_address would reset it.
>
> You forgot space after * here.
>
> WBR, Sergei
>
Okay i'll be sending them in separate and correcting a space issue as told.
thanks

Regards
Kumar Gaurav