SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
two regulators. The dt node is split to reflect it.
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/omap5-uevm.dts | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index 65d7b60..05b9b12 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -334,9 +334,18 @@
ti,smps-range = <0x80>;
};
- smps10_reg: smps10 {
+ smps10_out2_reg: smps10_out2 {
/* VBUS_5V_OTG */
- regulator-name = "smps10";
+ regulator-name = "smps10_out2";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
+ smps10_out1_reg: smps10_out1 {
+ /* VBUS_5V_OTG */
+ regulator-name = "smps10_out1";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
regulator-always-on;
--
1.7.10.4
Hi Kishon,
On 12/08/2013 11:37, Kishon Vijay Abraham I wrote:
> SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
> two regulators. The dt node is split to reflect it.
Mmm, I'm curious. How is it supposed to work?
Do you have dedicated control on each output?
Otherwise, it should be seen as one output with two potential consumers.
Regards,
Benoit
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index 65d7b60..05b9b12 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -334,9 +334,18 @@
> ti,smps-range = <0x80>;
> };
>
> - smps10_reg: smps10 {
> + smps10_out2_reg: smps10_out2 {
> /* VBUS_5V_OTG */
> - regulator-name = "smps10";
> + regulator-name = "smps10_out2";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> + smps10_out1_reg: smps10_out1 {
> + /* VBUS_5V_OTG */
> + regulator-name = "smps10_out1";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> regulator-always-on;
>
Hi,
On Tuesday 13 August 2013 06:51 PM, Benoit Cousson wrote:
> Hi Kishon,
>
> On 12/08/2013 11:37, Kishon Vijay Abraham I wrote:
>> SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
>> two regulators. The dt node is split to reflect it.
>
> Mmm, I'm curious. How is it supposed to work?
>
> Do you have dedicated control on each output?
Yes. It can be controlled by setting different values to the same bit fields.
You can refer [1] where we actually implement SMPS10 as two different regulators.
[1] -> http://permalink.gmane.org/gmane.linux.kernel/1542521
Thanks
Kishon
On 13/08/2013 16:45, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 13 August 2013 06:51 PM, Benoit Cousson wrote:
>> Hi Kishon,
>>
>> On 12/08/2013 11:37, Kishon Vijay Abraham I wrote:
>>> SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
>>> two regulators. The dt node is split to reflect it.
>>
>> Mmm, I'm curious. How is it supposed to work?
>>
>> Do you have dedicated control on each output?
>
> Yes. It can be controlled by setting different values to the same bit fields.
> You can refer [1] where we actually implement SMPS10 as two different regulators.
>
> [1] -> http://permalink.gmane.org/gmane.linux.kernel/1542521
Great, thanks.
Can we merge that one safely if the driver changed are not done yet?
Regards,
Benoit
Hi Benoit,
On Tuesday 13 August 2013 08:18 PM, Benoit Cousson wrote:
> On 13/08/2013 16:45, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Tuesday 13 August 2013 06:51 PM, Benoit Cousson wrote:
>>> Hi Kishon,
>>>
>>> On 12/08/2013 11:37, Kishon Vijay Abraham I wrote:
>>>> SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
>>>> two regulators. The dt node is split to reflect it.
>>>
>>> Mmm, I'm curious. How is it supposed to work?
>>>
>>> Do you have dedicated control on each output?
>>
>> Yes. It can be controlled by setting different values to the same bit fields.
>> You can refer [1] where we actually implement SMPS10 as two different
>> regulators.
>>
>> [1] -> http://permalink.gmane.org/gmane.linux.kernel/1542521
>
> Great, thanks.
>
> Can we merge that one safely if the driver changed are not done yet?
I think it shouldn't cause any issues. However Mark has already merged the
driver changes.
Thanks
Kishon
On 16/08/2013 07:15, Kishon Vijay Abraham I wrote:
> Hi Benoit,
>
> On Tuesday 13 August 2013 08:18 PM, Benoit Cousson wrote:
>> On 13/08/2013 16:45, Kishon Vijay Abraham I wrote:
>>> Hi,
>>>
>>> On Tuesday 13 August 2013 06:51 PM, Benoit Cousson wrote:
>>>> Hi Kishon,
>>>>
>>>> On 12/08/2013 11:37, Kishon Vijay Abraham I wrote:
>>>>> SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
>>>>> two regulators. The dt node is split to reflect it.
>>>>
>>>> Mmm, I'm curious. How is it supposed to work?
>>>>
>>>> Do you have dedicated control on each output?
>>>
>>> Yes. It can be controlled by setting different values to the same bit fields.
>>> You can refer [1] where we actually implement SMPS10 as two different
>>> regulators.
>>>
>>> [1] -> http://permalink.gmane.org/gmane.linux.kernel/1542521
>>
>> Great, thanks.
>>
>> Can we merge that one safely if the driver changed are not done yet?
>
> I think it shouldn't cause any issues. However Mark has already merged the
> driver changes.
Cool. I've just applied your patch in for_3.12/dts
Thanks,
Benoit
On Friday 16 August 2013 02:24 PM, Benoit Cousson wrote:
> On 16/08/2013 07:15, Kishon Vijay Abraham I wrote:
>> Hi Benoit,
>>
>> On Tuesday 13 August 2013 08:18 PM, Benoit Cousson wrote:
>>> On 13/08/2013 16:45, Kishon Vijay Abraham I wrote:
>>>> Hi,
>>>>
>>>> On Tuesday 13 August 2013 06:51 PM, Benoit Cousson wrote:
>>>>> Hi Kishon,
>>>>>
>>>>> On 12/08/2013 11:37, Kishon Vijay Abraham I wrote:
>>>>>> SMPS10 has two outputs OUT1 and OUT2. Hence SMPS10 is modeled as
>>>>>> two regulators. The dt node is split to reflect it.
>>>>>
>>>>> Mmm, I'm curious. How is it supposed to work?
>>>>>
>>>>> Do you have dedicated control on each output?
>>>>
>>>> Yes. It can be controlled by setting different values to the same bit fields.
>>>> You can refer [1] where we actually implement SMPS10 as two different
>>>> regulators.
>>>>
>>>> [1] -> http://permalink.gmane.org/gmane.linux.kernel/1542521
>>>
>>> Great, thanks.
>>>
>>> Can we merge that one safely if the driver changed are not done yet?
>>
>> I think it shouldn't cause any issues. However Mark has already merged the
>> driver changes.
>
> Cool. I've just applied your patch in for_3.12/dts
Thanks :-)
Regards
Kishon