From: Lars Poeschel <[email protected]>
Following commit ff5c9059 and therefore other omap platforms using
the gpio-omap driver correct the #interrupt-cells property on am33xx
too. The omap gpio binding documentaion also states that
the #interrupt-cells property should be 2.
Signed-off-by: Lars Poeschel <[email protected]>
---
arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 38b446b..033c5dd 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -102,7 +102,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
reg = <0x44e07000 0x1000>;
interrupts = <96>;
};
@@ -113,7 +113,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
reg = <0x4804c000 0x1000>;
interrupts = <98>;
};
@@ -124,7 +124,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
reg = <0x481ac000 0x1000>;
interrupts = <32>;
};
@@ -135,7 +135,7 @@
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
- #interrupt-cells = <1>;
+ #interrupt-cells = <2>;
reg = <0x481ae000 0x1000>;
interrupts = <62>;
};
--
1.7.10.4
On Wed, Aug 7, 2013 at 1:06 PM, Lars Poeschel <[email protected]> wrote:
> From: Lars Poeschel <[email protected]>
>
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.
>
> Signed-off-by: Lars Poeschel <[email protected]>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x44e07000 0x1000>;
> interrupts = <96>;
> };
> @@ -113,7 +113,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x4804c000 0x1000>;
> interrupts = <98>;
> };
> @@ -124,7 +124,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ac000 0x1000>;
> interrupts = <32>;
> };
> @@ -135,7 +135,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ae000 0x1000>;
> interrupts = <62>;
> };
> --
> 1.7.10.4
>
>
Reviewed-by: Javier Martinez Canillas <[email protected]>
On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
> From: Lars Poeschel <[email protected]>
>
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.
I take it there are no device nodes for which any of these nodes are an
interrupt parent (which would need to be updated)?
If so:
Acked-by: Mark Rutland <[email protected]>
Thanks,
Mark.
>
> Signed-off-by: Lars Poeschel <[email protected]>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x44e07000 0x1000>;
> interrupts = <96>;
> };
> @@ -113,7 +113,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x4804c000 0x1000>;
> interrupts = <98>;
> };
> @@ -124,7 +124,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ac000 0x1000>;
> interrupts = <32>;
> };
> @@ -135,7 +135,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ae000 0x1000>;
> interrupts = <62>;
> };
> --
> 1.7.10.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
On Wednesday 07 August 2013 at 16:53:09, Mark Rutland wrote:
> On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
> > From: Lars Poeschel <[email protected]>
> >
> > Following commit ff5c9059 and therefore other omap platforms using
> > the gpio-omap driver correct the #interrupt-cells property on am33xx
> > too. The omap gpio binding documentaion also states that
> > the #interrupt-cells property should be 2.
>
> I take it there are no device nodes for which any of these nodes are an
> interrupt parent (which would need to be updated)?
As far as I know: No.
Lars
> If so:
>
> Acked-by: Mark Rutland <[email protected]>
>
> Thanks,
> Mark.
>
> > Signed-off-by: Lars Poeschel <[email protected]>
> > ---
> >
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> > b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..033c5dd 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -102,7 +102,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x44e07000 0x1000>;
> > interrupts = <96>;
> >
> > };
> >
> > @@ -113,7 +113,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x4804c000 0x1000>;
> > interrupts = <98>;
> >
> > };
> >
> > @@ -124,7 +124,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ac000 0x1000>;
> > interrupts = <32>;
> >
> > };
> >
> > @@ -135,7 +135,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ae000 0x1000>;
> > interrupts = <62>;
> >
> > };
Hi lars,
On 07/08/2013 17:11, Lars Poeschel wrote:
> On Wednesday 07 August 2013 at 16:53:09, Mark Rutland wrote:
>> On Wed, Aug 07, 2013 at 12:06:32PM +0100, Lars Poeschel wrote:
>>> From: Lars Poeschel <[email protected]>
>>>
>>> Following commit ff5c9059 and therefore other omap platforms using
>>> the gpio-omap driver correct the #interrupt-cells property on am33xx
>>> too. The omap gpio binding documentaion also states that
>>> the #interrupt-cells property should be 2.
>>
>> I take it there are no device nodes for which any of these nodes are an
>> interrupt parent (which would need to be updated)?
>
> As far as I know: No.
>
> Lars
>
>> If so:
>>
>> Acked-by: Mark Rutland <[email protected]>
>>
>> Thanks,
>> Mark.
>>
>>> Signed-off-by: Lars Poeschel <[email protected]>
Thank, applied with Mark and Javier A-By / R-By.
Thanks,
Benoit
Benoit,
Care to take a look at this too?
* Lars Poeschel <[email protected]> [130807 04:14]:
> From: Lars Poeschel <[email protected]>
>
> Following commit ff5c9059 and therefore other omap platforms using
> the gpio-omap driver correct the #interrupt-cells property on am33xx
> too. The omap gpio binding documentaion also states that
> the #interrupt-cells property should be 2.
>
> Signed-off-by: Lars Poeschel <[email protected]>
> ---
> arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 38b446b..033c5dd 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -102,7 +102,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x44e07000 0x1000>;
> interrupts = <96>;
> };
> @@ -113,7 +113,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x4804c000 0x1000>;
> interrupts = <98>;
> };
> @@ -124,7 +124,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ac000 0x1000>;
> interrupts = <32>;
> };
> @@ -135,7 +135,7 @@
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> - #interrupt-cells = <1>;
> + #interrupt-cells = <2>;
> reg = <0x481ae000 0x1000>;
> interrupts = <62>;
> };
> --
> 1.7.10.4
>
Hi Tony!
On Wednesday 21 August 2013 at 09:50:16, Tony Lindgren wrote:
> Benoit,
>
> Care to take a look at this too?
Benoit already applied this with Mark Rutlands Acked-By and Javier Martinez
Canillas Reviewed-by.
Regards,
Lars
> * Lars Poeschel <[email protected]> [130807 04:14]:
> > From: Lars Poeschel <[email protected]>
> >
> > Following commit ff5c9059 and therefore other omap platforms using
> > the gpio-omap driver correct the #interrupt-cells property on am33xx
> > too. The omap gpio binding documentaion also states that
> > the #interrupt-cells property should be 2.
> >
> > Signed-off-by: Lars Poeschel <[email protected]>
> > ---
> >
> > arch/arm/boot/dts/am33xx.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> > b/arch/arm/boot/dts/am33xx.dtsi index 38b446b..033c5dd 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -102,7 +102,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x44e07000 0x1000>;
> > interrupts = <96>;
> >
> > };
> >
> > @@ -113,7 +113,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x4804c000 0x1000>;
> > interrupts = <98>;
> >
> > };
> >
> > @@ -124,7 +124,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ac000 0x1000>;
> > interrupts = <32>;
> >
> > };
> >
> > @@ -135,7 +135,7 @@
> >
> > gpio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> >
> > - #interrupt-cells = <1>;
> > + #interrupt-cells = <2>;
> >
> > reg = <0x481ae000 0x1000>;
> > interrupts = <62>;
> >
> > };
* Lars Poeschel <[email protected]> [130821 01:04]:
> Hi Tony!
>
> On Wednesday 21 August 2013 at 09:50:16, Tony Lindgren wrote:
> > Benoit,
> >
> > Care to take a look at this too?
>
> Benoit already applied this with Mark Rutlands Acked-By and Javier Martinez
> Canillas Reviewed-by.
OK thanks for the update, I'm just trying to follow-up and clear
my inbox a bit.
Tony
Hi Tony,
On 21/08/2013 09:59, Tony Lindgren wrote:
> * Lars Poeschel <[email protected]> [130821 01:04]:
>> Hi Tony!
>>
>> On Wednesday 21 August 2013 at 09:50:16, Tony Lindgren wrote:
>>> Benoit,
>>>
>>> Care to take a look at this too?
>>
>> Benoit already applied this with Mark Rutlands Acked-By and Javier Martinez
>> Canillas Reviewed-by.
>
> OK thanks for the update, I'm just trying to follow-up and clear
> my inbox a bit.
I've just checked, because I thought I missed it, and this is indeed in
my pull request I sent you yesterday.
Thanks,
Benoit