2013-08-12 13:27:46

by Libo Chen

Subject: [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index c93a056..995a3ab 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -409,7 +409,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
priv->regs = priv->map + data->mii_offset;

new_bus->parent = &pdev->dev;
- dev_set_drvdata(&pdev->dev, new_bus);
+ platform_set_drvdata(pdev, new_bus);

if (data->get_tbipa) {
for_each_child_of_node(np, tbi) {
@@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)

mdiobus_unregister(bus);

- dev_set_drvdata(device, NULL);

iounmap(priv->map);
mdiobus_free(bus);
--
1.7.1

2013-08-12 18:10:43

by Sergei Shtylyov

Subject: Re: [PATCH 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

Hello.

On 08/12/2013 05:24 PM, Libo Chen wrote:

> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.

> Signed-off-by: Libo Chen <[email protected]>
> ---
> drivers/net/ethernet/freescale/fsl_pq_mdio.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)

> diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> index c93a056..995a3ab 100644
> --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
[...]
> @@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)
>
> mdiobus_unregister(bus);
>
> - dev_set_drvdata(device, NULL);

You don't mention this in the changelog.

WBR, Sergei

2013-08-14 03:41:54

by Libo Chen

Subject: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

We can use the wrapper functions platform_{get,set}_drvdata() instead of
dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/freescale/fsl_pq_mdio.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
index c93a056..995a3ab 100644
--- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
+++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
@@ -409,7 +409,7 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
priv->regs = priv->map + data->mii_offset;

new_bus->parent = &pdev->dev;
- dev_set_drvdata(&pdev->dev, new_bus);
+ platform_set_drvdata(pdev, new_bus);

if (data->get_tbipa) {
for_each_child_of_node(np, tbi) {
@@ -468,7 +468,6 @@ static int fsl_pq_mdio_remove(struct platform_device *pdev)

mdiobus_unregister(bus);

- dev_set_drvdata(device, NULL);

iounmap(priv->map);
mdiobus_free(bus);
--
1.7.1

2013-08-14 18:54:40

by Sergei Shtylyov

Subject: Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

Hello.

On 08/14/2013 07:39 AM, Libo Chen wrote:

> We can use the wrapper functions platform_{get,set}_drvdata() instead of
> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.

> Also, unnecessary dev_set_drvdata() is removed, because the driver core
> clears the driver data to NULL after device_release or on probe failure.

You misunderstood. That's a material for 2 separate patch sets (or maybe
single patches, since multiple files can be collapsed in a single patch).

> Signed-off-by: Libo Chen <[email protected]>

WBR, Sergei

2013-08-15 09:28:10

by Libo Chen

Subject: Re: [PATCH RESEND 1/8] net: fsl_pq_mdio: use platform_{get,set}_drvdata()

On 2013/8/15 2:54, Sergei Shtylyov wrote:
> Hello.
>
> On 08/14/2013 07:39 AM, Libo Chen wrote:
>
>> We can use the wrapper functions platform_{get,set}_drvdata() instead of
>> dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.
>
>> Also, unnecessary dev_set_drvdata() is removed, because the driver core
>> clears the driver data to NULL after device_release or on probe failure.
>
> You misunderstood. That's a material for 2 separate patch sets (or maybe single patches, since multiple files can be collapsed in a single patch).
>

okay, thanks.


Libo

>> Signed-off-by: Libo Chen <[email protected]>
>
> WBR, Sergei
>
>
>