2013-08-12 13:25:30

by Libo Chen

Subject: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 16ddfc3..2249b2c 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -421,8 +421,7 @@ bail_out:

static int davinci_mdio_remove(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
- struct davinci_mdio_data *data = dev_get_drvdata(dev);
+ struct davinci_mdio_data *data = platform_get_drvdata(pdev);

if (data->bus) {
mdiobus_unregister(data->bus);
@@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);

- dev_set_drvdata(dev, NULL);

kfree(data);

--
1.7.1

2013-08-12 16:53:30

by Mugunthan V N

Subject: Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

On Monday 12 August 2013 06:55 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Libo Chen <[email protected]>
Looks good.
Acked-by: Mugunthan V N <[email protected]>

Regards
Mugunthan V N

2013-08-12 18:17:51

by Sergei Shtylyov

Subject: Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

On 08/12/2013 05:25 PM, Libo Chen wrote:

> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.

> Signed-off-by: Libo Chen <[email protected]>
> ---
> drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)

> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
> index 16ddfc3..2249b2c 100644
> --- a/drivers/net/ethernet/ti/davinci_mdio.c
> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
[...]
> @@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
> pm_runtime_put_sync(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
>
> - dev_set_drvdata(dev, NULL);

Doesn't get described as well. I think you're mixing two types of changes
in one patchset.

WBR, Sergei

2013-08-12 19:58:55

by David Miller

Subject: Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

From: Sergei Shtylyov <[email protected]>
Date: Mon, 12 Aug 2013 22:17:47 +0400

> Doesn't get described as well. I think you're mixing two types of
> changes in one patchset.

Agreed, you're going to have to redo this entire patch set.

2013-08-13 01:22:53

by Libo Chen

Subject: Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

On 2013/8/13 4:04, David Miller wrote:
> From: Sergei Shtylyov <[email protected]>
> Date: Mon, 12 Aug 2013 22:17:47 +0400
>
>> Doesn't get described as well. I think you're mixing two types of
>> changes in one patchset.
>
> Agreed, you're going to have to redo this entire patch set.
>

okay, I will redo!

2013-08-13 01:23:42

by Libo Chen

Subject: Re: [PATCH 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

On 2013/8/13 2:17, Sergei Shtylyov wrote:
> On 08/12/2013 05:25 PM, Libo Chen wrote:
>
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
>> so we can directly pass a struct platform_device.
>
>> Signed-off-by: Libo Chen <[email protected]>
>> ---
>> drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
>> 1 files changed, 1 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
>> index 16ddfc3..2249b2c 100644
>> --- a/drivers/net/ethernet/ti/davinci_mdio.c
>> +++ b/drivers/net/ethernet/ti/davinci_mdio.c
> [...]
>> @@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
>> pm_runtime_put_sync(&pdev->dev);
>> pm_runtime_disable(&pdev->dev);
>>
>> - dev_set_drvdata(dev, NULL);
>
> Doesn't get described as well. I think you're mixing two types of changes in one patchset.
>
> WBR, Sergei
>

thanks for your attention!


Libo

>
>

2013-08-14 03:40:42

by Libo Chen

Subject: [PATCH RESEND 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

We can use the wrapper functions platform_{get,set}_drvdata() instead of
dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.

Also, unnecessary dev_set_drvdata() is removed, because the driver core
clears the driver data to NULL after device_release or on probe failure.


Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 16ddfc3..2249b2c 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -421,8 +421,7 @@ bail_out:

static int davinci_mdio_remove(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
- struct davinci_mdio_data *data = dev_get_drvdata(dev);
+ struct davinci_mdio_data *data = platform_get_drvdata(pdev);

if (data->bus) {
mdiobus_unregister(data->bus);
@@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
pm_runtime_put_sync(&pdev->dev);
pm_runtime_disable(&pdev->dev);

- dev_set_drvdata(dev, NULL);

kfree(data);

--
1.7.1