The return type of ffs() is 'int' on all architectures except cris and
hexagon. This unifies the return type to 'int'.
The problem I'm seeing is that the following line generates a warning
on cris and hexagon because of the mismatch between format '%u' and
return type of ffs().
printk("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1);
But removing this warning by casting to 'int' looks odd, so I suggest
unifying the return type of ffs() on all architectures.
Signed-off-by: Akinobu Mita <[email protected]>
Reported-by: Fengguang Wu <[email protected]>
Cc: Mikael Starvik <[email protected]>
Cc: Jesper Nilsson <[email protected]>
Cc: [email protected]
Cc: Richard Kuo <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
This patch is not compile tested yet, because I couldn't find cross
compiler for hexagon.
arch/hexagon/include/asm/bitops.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/hexagon/include/asm/bitops.h b/arch/hexagon/include/asm/bitops.h
index 9b1e4af..80e34a6 100644
--- a/arch/hexagon/include/asm/bitops.h
+++ b/arch/hexagon/include/asm/bitops.h
@@ -234,7 +234,7 @@ static inline long fls(int x)
* the libc and compiler builtin ffs routines, therefore
* differs in spirit from the above ffz (man ffs).
*/
-static inline long ffs(int x)
+static inline int ffs(int x)
{
int r;
--
1.8.3.1
The return type of ffs() is 'int' on all architectures except cris and
hexagon. This unifies the return type to 'int'.
The problem I'm seeing is that the following line generates a warning
on cris and hexagon because of the mismatch between format '%u' and
return type of ffs().
printk("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1);
But removing this warning by casting to 'int' looks odd, so I suggest
unifying the return type of ffs() on all architectures.
Signed-off-by: Akinobu Mita <[email protected]>
Reported-by: Fengguang Wu <[email protected]>
Cc: Mikael Starvik <[email protected]>
Cc: Jesper Nilsson <[email protected]>
Cc: [email protected]
Cc: Richard Kuo <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
arch/cris/include/arch-v10/arch/bitops.h | 2 +-
arch/cris/include/arch-v32/arch/bitops.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/cris/include/arch-v10/arch/bitops.h b/arch/cris/include/arch-v10/arch/bitops.h
index 03d9cfd..cc37a22 100644
--- a/arch/cris/include/arch-v10/arch/bitops.h
+++ b/arch/cris/include/arch-v10/arch/bitops.h
@@ -65,7 +65,7 @@ static inline unsigned long __ffs(unsigned long word)
* differs in spirit from the above ffz (man ffs).
*/
-static inline unsigned long kernel_ffs(unsigned long w)
+static inline int kernel_ffs(unsigned long w)
{
return w ? cris_swapwbrlz (w) + 1 : 0;
}
diff --git a/arch/cris/include/arch-v32/arch/bitops.h b/arch/cris/include/arch-v32/arch/bitops.h
index 147689d6..a5d0963 100644
--- a/arch/cris/include/arch-v32/arch/bitops.h
+++ b/arch/cris/include/arch-v32/arch/bitops.h
@@ -55,7 +55,7 @@ __ffs(unsigned long w)
/*
* Find First Bit that is set.
*/
-static inline unsigned long
+static inline int
kernel_ffs(unsigned long w)
{
return w ? cris_swapwbrlz (w) + 1 : 0;
--
1.8.3.1
On 08/07/2013 08:42 AM, Akinobu Mita wrote:
> The return type of ffs() is 'int' on all architectures except cris and
> hexagon. This unifies the return type to 'int'.
>
> The problem I'm seeing is that the following line generates a warning
> on cris and hexagon because of the mismatch between format '%u' and
> return type of ffs().
>
> printk("bits in OOB size: %u\n", ffs(ns->geom.oobsz) - 1);
>
> But removing this warning by casting to 'int' looks odd, so I suggest
> unifying the return type of ffs() on all architectures.
>
> Signed-off-by: Akinobu Mita <[email protected]>
> Reported-by: Fengguang Wu <[email protected]>
> Cc: Mikael Starvik <[email protected]>
> Cc: Jesper Nilsson <[email protected]>
> Cc: [email protected]
> Cc: Richard Kuo <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> This patch is not compile tested yet, because I couldn't find cross
> compiler for hexagon.
>
> arch/hexagon/include/asm/bitops.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/bitops.h b/arch/hexagon/include/asm/bitops.h
> index 9b1e4af..80e34a6 100644
> --- a/arch/hexagon/include/asm/bitops.h
> +++ b/arch/hexagon/include/asm/bitops.h
> @@ -234,7 +234,7 @@ static inline long fls(int x)
> * the libc and compiler builtin ffs routines, therefore
> * differs in spirit from the above ffz (man ffs).
> */
> -static inline long ffs(int x)
> +static inline int ffs(int x)
> {
> int r;
>
For Hexagon:
Acked-by: Richard Kuo <[email protected]>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation