2013-08-15 13:02:11

by Libo Chen

[permalink] [raw]
Subject: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
so we can directly pass a struct platform_device.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/ti/davinci_mdio.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
index 16ddfc3..01b0cc5 100644
--- a/drivers/net/ethernet/ti/davinci_mdio.c
+++ b/drivers/net/ethernet/ti/davinci_mdio.c
@@ -421,8 +421,7 @@ bail_out:

static int davinci_mdio_remove(struct platform_device *pdev)
{
- struct device *dev = &pdev->dev;
- struct davinci_mdio_data *data = dev_get_drvdata(dev);
+ struct davinci_mdio_data *data = platform_get_drvdata(pdev);

if (data->bus) {
mdiobus_unregister(data->bus);
--
1.7.1


2013-08-16 17:15:27

by Prabhakar

[permalink] [raw]
Subject: Re: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

On Thu, Aug 15, 2013 at 6:31 PM, Libo Chen <[email protected]> wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Libo Chen <[email protected]>

Acked-by: Lad, Prabhakar <[email protected]>

Regards,
--Prabhakar Lad

2013-08-17 11:52:26

by Mugunthan V N

[permalink] [raw]
Subject: Re: [PATCH v3 7/7] net: davinci_mdio: use platform_{get,set}_drvdata()

On Thursday 15 August 2013 06:31 PM, Libo Chen wrote:
> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &pdev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Libo Chen <[email protected]>
I had given my ack for your previous version itself, I don't know why
you didn't add my Ack in next version.
Any how

Acked-by: Mugunthan V N <[email protected]>

Regards
Mugunthan V N