2013-08-15 13:03:15

by Libo Chen

Subject: [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata()

Use the wrapper functions for getting and setting the driver data using
platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev,
so we can directly pass a struct platform_device.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
index fd4dbda..7c1ccbc 100644
--- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c
+++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c
@@ -1230,8 +1230,7 @@ error:
*/
static int xemaclite_of_remove(struct platform_device *of_dev)
{
- struct device *dev = &of_dev->dev;
- struct net_device *ndev = dev_get_drvdata(dev);
+ struct net_device *ndev = platform_get_drvdata(of_dev);

struct net_local *lp = netdev_priv(ndev);

--
1.7.1

2013-08-15 22:23:29

by David Miller

Subject: Re: [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata()

From: Libo Chen <[email protected]>
Date: Thu, 15 Aug 2013 21:01:47 +0800

> Use the wrapper functions for getting and setting the driver data using
> platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev,
> so we can directly pass a struct platform_device.
>
> Signed-off-by: Libo Chen <[email protected]>

Why did you not CC: netdev on this patch?

2013-08-16 01:09:50

by Libo Chen

Subject: Re: [PATCH v3 6/7] net: xilinx_emaclite: use platform_{get,set}_drvdata()

On 2013/8/16 6:23, David Miller wrote:
> From: Libo Chen <[email protected]>
> Date: Thu, 15 Aug 2013 21:01:47 +0800
>
>> Use the wrapper functions for getting and setting the driver data using
>> platform_device instead of using dev_{get,set}_drvdata() with &of_dev->dev,
>> so we can directly pass a struct platform_device.
>>
>> Signed-off-by: Libo Chen <[email protected]>
>
> Why did you not CC: netdev on this patch?
>

oh, my script doesn`t work well!

>