2008-08-01 13:40:05

by John Kacur

[permalink] [raw]
Subject: [PATCH] rt Kconfig.preempt fixes

This is a non-critical patch, that makes configuring an rt kernel a
little nicer.
Comments are welcome of course.

Signed-off-by: John Kacur <jkacur at gmail dot com>

This patch makes the following changes.
1. Hides the visibility of PREEMPT_SOFTIRQS and PREEMPT_HARDIRQS if PREEMPT_RT
(Complete Preemption) is choosen, since these values are then set (selected) to
be "y".

2. Changes the PREEMPT_HARDIRQS to depend on PREEMPT_SOFTIRQS instead of
forcing PREEMPT_SOFTIRQS to y if PREEMPT_HARDIRQS is choosen. (this is somewhat
an abuse of select)

3. Minor spelling fix. (tat to that)


Attachments:
(No filename) (587.00 B)
threaded-irqs-kconfig-fix.patch (1.98 kB)
Download all attachments

2008-08-20 16:11:05

by Steven Rostedt

[permalink] [raw]
Subject: Re: [PATCH] rt Kconfig.preempt fixes



On Fri, 1 Aug 2008, John Kacur wrote:

> This is a non-critical patch, that makes configuring an rt kernel a
> little nicer.
> Comments are welcome of course.
>
> Signed-off-by: John Kacur <jkacur at gmail dot com>
>
> This patch makes the following changes.
> 1. Hides the visibility of PREEMPT_SOFTIRQS and PREEMPT_HARDIRQS if PREEMPT_RT
> (Complete Preemption) is choosen, since these values are then set (selected) to
> be "y".
>
> 2. Changes the PREEMPT_HARDIRQS to depend on PREEMPT_SOFTIRQS instead of
> forcing PREEMPT_SOFTIRQS to y if PREEMPT_HARDIRQS is choosen. (this is somewhat
> an abuse of select)
>
> 3. Minor spelling fix. (tat to that)
>


Hi John,

Thanks, but instead of this:

depends on PREEMPT_RT != y

could you do:

depends on !PREEMPT_RT


-- Steve

2008-08-20 17:14:54

by John Kacur

[permalink] [raw]
Subject: Re: [PATCH] rt Kconfig.preempt fixes

On Wed, Aug 20, 2008 at 6:10 PM, Steven Rostedt <[email protected]> wrote:
>
>
> On Fri, 1 Aug 2008, John Kacur wrote:
>
>> This is a non-critical patch, that makes configuring an rt kernel a
>> little nicer.
>> Comments are welcome of course.
>>
>> Signed-off-by: John Kacur <jkacur at gmail dot com>
>>
>> This patch makes the following changes.
>> 1. Hides the visibility of PREEMPT_SOFTIRQS and PREEMPT_HARDIRQS if PREEMPT_RT
>> (Complete Preemption) is choosen, since these values are then set (selected) to
>> be "y".
>>
>> 2. Changes the PREEMPT_HARDIRQS to depend on PREEMPT_SOFTIRQS instead of
>> forcing PREEMPT_SOFTIRQS to y if PREEMPT_HARDIRQS is choosen. (this is somewhat
>> an abuse of select)
>>
>> 3. Minor spelling fix. (tat to that)
>>
>
>
> Hi John,
>
> Thanks, but instead of this:
>
> depends on PREEMPT_RT != y
>
> could you do:
>
> depends on !PREEMPT_RT
>
>
> -- Steve
>

Yes, regenerated patch attached.

Thanks


Attachments:
(No filename) (942.00 B)
threaded-irqs-kconfig-fix.patch (1.91 kB)
Download all attachments