2013-08-21 15:20:09

by Lars Poeschel

[permalink] [raw]
Subject: [PATCH] of: add vendor prefix for Microchip Technology Inc

Trivial patch to add Microchip Technology Inc. to the list
of devicetree vendor prefixes, as it is already used in
Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt

Signed-off-by: Lars Poeschel <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
b/Documentation/devicetree/bindings/vendor-prefixes.txt
index 366ce9b..b3b2ad7 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.txt
+++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
@@ -36,6 +36,7 @@ linux Linux-specific binding
lsi LSI Corp. (LSI Logic)
marvell Marvell Technology Group Ltd.
maxim Maxim Integrated Products
+mcp Microchip Technology Inc.
mosaixtech Mosaix Technologies, Inc.
national National Semiconductor
nintendo Nintendo
--
1.7.10.4


2013-08-21 17:41:01

by Stephen Warren

[permalink] [raw]
Subject: Re: [PATCH] of: add vendor prefix for Microchip Technology Inc

On 08/21/2013 09:19 AM, Lars Poeschel wrote:
> Trivial patch to add Microchip Technology Inc. to the list
> of devicetree vendor prefixes, as it is already used in
> Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt

Oh dear. Perhaps it can be legacy-ified...

> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

> +mcp Microchip Technology Inc.

If I saw "mcp," in a *.dts file, I wouldn't immediately think "Microchip".

Their stock ticker appears to be MCHP, so I'd suggest either "mchp" or
"microchip" instead; that latter being my personal preference.

2013-08-22 07:47:41

by Lars Poeschel

[permalink] [raw]
Subject: Re: [PATCH] of: add vendor prefix for Microchip Technology Inc

On Wednesday 21 August 2013 at 19:40:56, Stephen Warren wrote:
> On 08/21/2013 09:19 AM, Lars Poeschel wrote:
> > Trivial patch to add Microchip Technology Inc. to the list
> > of devicetree vendor prefixes, as it is already used in
> > Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
>
> Oh dear. Perhaps it can be legacy-ified...
>
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> >
> > +mcp Microchip Technology Inc.
>
> If I saw "mcp," in a *.dts file, I wouldn't immediately think
> "Microchip".
>
> Their stock ticker appears to be MCHP, so I'd suggest either "mchp" or
> "microchip" instead; that latter being my personal preference.

Any other opinions?
If there are other voices who don't like it, we can change it. There is no
in-tree dts file using this yet.
How can a renaming be done? Would that involve changing the drivers (and
module) name too? Or do we have the difference between "mcp" in the drivers
name and "microchip" for device tree properties? In the latter case, I'd
vote against it - if anyone cares. ;-)

Lars

2013-08-22 07:53:32

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH] of: add vendor prefix for Microchip Technology Inc

Hello,

2013/8/22 Lars Poeschel <[email protected]>:
> On Wednesday 21 August 2013 at 19:40:56, Stephen Warren wrote:
>> On 08/21/2013 09:19 AM, Lars Poeschel wrote:
>> > Trivial patch to add Microchip Technology Inc. to the list
>> > of devicetree vendor prefixes, as it is already used in
>> > Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
>>
>> Oh dear. Perhaps it can be legacy-ified...
>>
>> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
>> >
>> > +mcp Microchip Technology Inc.
>>
>> If I saw "mcp," in a *.dts file, I wouldn't immediately think
>> "Microchip".
>>
>> Their stock ticker appears to be MCHP, so I'd suggest either "mchp" or
>> "microchip" instead; that latter being my personal preference.
>
> Any other opinions?
> If there are other voices who don't like it, we can change it. There is no
> in-tree dts file using this yet.
> How can a renaming be done? Would that involve changing the drivers (and
> module) name too? Or do we have the difference between "mcp" in the drivers
> name and "microchip" for device tree properties? In the latter case, I'd
> vote against it - if anyone cares. ;-)

We have recently had an interesting debate for the Broadcom vendor
prefix, so in light of this debate, I would go for the full name
directly and use "microchip". That said, this does not necessarily
mean that drivers containing "mcp" in their files/filenames must also
be renamed.
--
Florian

2013-08-22 09:04:05

by Lars Poeschel

[permalink] [raw]
Subject: Re: [PATCH] of: add vendor prefix for Microchip Technology Inc

On Thursday 22 August 2013 at 09:52:49, Florian Fainelli wrote:
> Hello,
>
> 2013/8/22 Lars Poeschel <[email protected]>:
> > On Wednesday 21 August 2013 at 19:40:56, Stephen Warren wrote:
> >> On 08/21/2013 09:19 AM, Lars Poeschel wrote:
> >> > Trivial patch to add Microchip Technology Inc. to the list
> >> > of devicetree vendor prefixes, as it is already used in
> >> > Documentation/devicetree/bindings/gpio/gpio-mcp23s08.txt
> >>
> >> Oh dear. Perhaps it can be legacy-ified...
> >>
> >> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
> >> >
> >> > +mcp Microchip Technology Inc.
> >>
> >> If I saw "mcp," in a *.dts file, I wouldn't immediately think
> >> "Microchip".
> >>
> >> Their stock ticker appears to be MCHP, so I'd suggest either "mchp"
> >> or "microchip" instead; that latter being my personal preference.
> >
> > Any other opinions?
> > If there are other voices who don't like it, we can change it. There
> > is no in-tree dts file using this yet.
> > How can a renaming be done? Would that involve changing the drivers
> > (and module) name too? Or do we have the difference between "mcp" in
> > the drivers name and "microchip" for device tree properties? In the
> > latter case, I'd vote against it - if anyone cares. ;-)
>
> We have recently had an interesting debate for the Broadcom vendor
> prefix, so in light of this debate, I would go for the full name
> directly and use "microchip". That said, this does not necessarily
> mean that drivers containing "mcp" in their files/filenames must also
> be renamed.

Ok, I'll provide a little patch series doing it that way.