2013-08-22 16:06:40

by Randy Dunlap

Subject: [PATCH] samsung-laptop: fix config build error

From: Randy Dunlap <[email protected]>

Fix build failure when ACPI_VIDEO=m and SAMSUNG_LAPTOP=y.
The patch prevents that specific config combination.

drivers/built-in.o: In function `samsung_init':
samsung-laptop.c:(.init.text+0x128ff): undefined reference to `acpi_video_unregister'

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: Randy Dunlap <[email protected]>
Reported-by: Fengguang Wu <[email protected]>
Cc: Corentin Chary <[email protected]>

build testing:
ACPI_VIDEO=m, SAMSUNG_LAPTOP=m: OK
ACPI_VIDEO=y, SAMSUNG_LAPTOP=m: OK
ACPI_VIDEO=y, SAMSUNG_LAPTOP=y: OK
ACPI=n, SAMSUNG_LAPTOP=y: OK
ACPI=n, SAMSUNG_LAPTOP=m: OK
---
drivers/platform/x86/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20130820.orig/drivers/platform/x86/Kconfig
+++ linux-next-20130820/drivers/platform/x86/Kconfig
@@ -732,6 +732,7 @@ config SAMSUNG_LAPTOP
tristate "Samsung Laptop driver"
depends on X86
depends on RFKILL || RFKILL = n
+ depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on BACKLIGHT_CLASS_DEVICE
select LEDS_CLASS
select NEW_LEDS

2013-09-03 12:07:32

by Matthew Garrett

Subject: Re: [PATCH] samsung-laptop: fix config build error

On Thu, 2013-08-22 at 09:06 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix build failure when ACPI_VIDEO=m and SAMSUNG_LAPTOP=y.
> The patch prevents that specific config combination.

Applied, thanks.

--
Matthew Garrett <[email protected]>
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?