2013-08-26 03:31:33

by Libo Chen

Subject: [PATCH] net: xilinx: fix memleak

decrease device_node refcount np1 in err case.

Signed-off-by: Libo Chen <[email protected]>
---
drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
index e90e1f4..64b4639 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
@@ -175,6 +175,7 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
printk(KERN_WARNING "Setting MDIO clock divisor to "
"default %d\n", DEFAULT_CLOCK_DIVISOR);
clk_div = DEFAULT_CLOCK_DIVISOR;
+ of_node_put(np1);
goto issue;
}

--
1.7.1

2013-08-28 22:25:06

by David Miller

Subject: Re: [PATCH] net: xilinx: fix memleak

From: Libo Chen <[email protected]>
Date: Mon, 26 Aug 2013 11:30:55 +0800

>
> decrease device_node refcount np1 in err case.
>
> Signed-off-by: Libo Chen <[email protected]>

Applied, thank you.