2013-08-22 01:49:15

by Wang Sheng-Hui

Subject: [PATCH] tile: add null check for kzalloc in tile/kernel/setup.c

Should check the return value of kzalloc first to avoid the null pointer.
Then can dereference the non-null pointer to access the fields of struct resource.

Signed-off-by: Wang Sheng-Hui <[email protected]>
---
arch/tile/kernel/setup.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/tile/kernel/setup.c b/arch/tile/kernel/setup.c
index eceb834..7d4138c 100644
--- a/arch/tile/kernel/setup.c
+++ b/arch/tile/kernel/setup.c
@@ -1548,6 +1548,8 @@ insert_non_bus_resource(void)
{
struct resource *res =
kzalloc(sizeof(struct resource), GFP_ATOMIC);
+ if (!res)
+ return NULL;
res->name = "Non-Bus Physical Address Space";
res->start = (1ULL << 32);
res->end = -1LL;
@@ -1565,6 +1567,8 @@ insert_ram_resource(u64 start_pfn, u64 end_pfn)
{
struct resource *res =
kzalloc(sizeof(struct resource), GFP_ATOMIC);
+ if (!res)
+ return NULL;
res->name = "System RAM";
res->start = start_pfn << PAGE_SHIFT;
res->end = (end_pfn << PAGE_SHIFT) - 1;
--
1.7.10.4

2013-08-29 18:03:00

by Chris Metcalf

Subject: Re: [PATCH] tile: add null check for kzalloc in tile/kernel/setup.c

On 8/21/2013 9:49 PM, Wang Sheng-Hui wrote:
> Should check the return value of kzalloc first to avoid the null pointer.
> Then can dereference the non-null pointer to access the fields of struct resource.
>
> Signed-off-by: Wang Sheng-Hui <[email protected]>
> ---
> arch/tile/kernel/setup.c | 4 ++++
> 1 file changed, 4 insertions(+)

Thanks. Taken into the tile tree.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com