2013-08-30 03:36:54

by Jianguo Wu

Subject: [PATCH 1/5] mm/vmalloc: use N_MEMORY instead of N_HIGH_MEMORY

Since commit 8219fc48a(mm: node_states: introduce N_MEMORY),
we introduced N_MEMORY, now N_MEMORY stands for the nodes that has any memory,
and N_HIGH_MEMORY stands for the nodes that has normal or high memory.

The code here need to handle with the nodes which have memory,
we should use N_MEMORY instead.

Signed-off-by: Jianguo Wu <[email protected]>
---
mm/vmalloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 13a5495..1152947 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -2573,7 +2573,7 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
for (nr = 0; nr < v->nr_pages; nr++)
counters[page_to_nid(v->pages[nr])]++;

- for_each_node_state(nr, N_HIGH_MEMORY)
+ for_each_node_state(nr, N_MEMORY)
if (counters[nr])
seq_printf(m, " N%u=%u", nr, counters[nr]);
}
--
1.7.1

2013-08-30 09:11:06

by Jianguo Wu

Subject: Re: [PATCH 1/5] mm/vmalloc: use N_MEMORY instead of N_HIGH_MEMORY

On 2013/8/30 11:36, Jianguo Wu wrote:

> Since commit 8219fc48a(mm: node_states: introduce N_MEMORY),
> we introduced N_MEMORY, now N_MEMORY stands for the nodes that has any memory,
> and N_HIGH_MEMORY stands for the nodes that has normal or high memory.
>
> The code here need to handle with the nodes which have memory,
> we should use N_MEMORY instead.
>

As Michal pointed out in http://marc.info/?l=linux-kernel&m=137784852720861&w=2,
N_HIGH_MEMORY should be kept in these places, please ignore this series.

Sorry for the noise.

Thanks.

> Signed-off-by: Jianguo Wu <[email protected]>
> ---
> mm/vmalloc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 13a5495..1152947 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2573,7 +2573,7 @@ static void show_numa_info(struct seq_file *m, struct vm_struct *v)
> for (nr = 0; nr < v->nr_pages; nr++)
> counters[page_to_nid(v->pages[nr])]++;
>
> - for_each_node_state(nr, N_HIGH_MEMORY)
> + for_each_node_state(nr, N_MEMORY)
> if (counters[nr])
> seq_printf(m, " N%u=%u", nr, counters[nr]);
> }