2013-09-02 15:54:31

by Randy Dunlap

Subject: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled

From: Randy Dunlap <[email protected]>

Fix build warnings when CONFIG_OF is not enabled:

include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default]
include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default]

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
---
include/linux/of_irq.h | 2 ++
1 file changed, 2 insertions(+)

--- linux-next-20130830.orig/include/linux/of_irq.h
+++ linux-next-20130830/include/linux/of_irq.h
@@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_
#endif /* CONFIG_OF_IRQ */

#else /* !CONFIG_OF */
+struct device_node;
+
static inline unsigned int irq_of_parse_and_map(struct device_node *dev,
int index)
{

2013-09-03 22:31:22

by Rob Herring

Subject: Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled

On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap <[email protected]> wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix build warnings when CONFIG_OF is not enabled:

It would be nice to know what arch/config you see this on.

> include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default]
> include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default]
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Grant Likely <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: [email protected]
> ---
> include/linux/of_irq.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20130830.orig/include/linux/of_irq.h
> +++ linux-next-20130830/include/linux/of_irq.h
> @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_
> #endif /* CONFIG_OF_IRQ */
>
> #else /* !CONFIG_OF */
> +struct device_node;

Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code.

Rob

2013-09-03 23:19:02

by Randy Dunlap

Subject: Re: [PATCH] of_irq.h: fix build warnings when CONFIG_OF is not enabled

On 09/03/13 15:31, Rob Herring wrote:
> On Mon, Sep 2, 2013 at 10:54 AM, Randy Dunlap <[email protected]> wrote:
>> From: Randy Dunlap <[email protected]>
>>
>> Fix build warnings when CONFIG_OF is not enabled:
>
> It would be nice to know what arch/config you see this on.

i386 and x86_64.

>
>> include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default]
>> include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>> include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default]
>>
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Grant Likely <[email protected]>
>> Cc: Rob Herring <[email protected]>
>> Cc: [email protected]
>> ---
>> include/linux/of_irq.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> --- linux-next-20130830.orig/include/linux/of_irq.h
>> +++ linux-next-20130830/include/linux/of_irq.h
>> @@ -78,6 +78,8 @@ extern void of_irq_init(const struct of_
>> #endif /* CONFIG_OF_IRQ */
>>
>> #else /* !CONFIG_OF */
>> +struct device_node;
>
> Can you move this outside of the ifdefs to minimize the amount of ifdef'ed code.

I'm build testing that change now, but it seems odd to have it there in 2 ways
when CONFIG_OF is enabled:


struct device_node;

#if defined(CONFIG_OF)

#include <linux/of.h>



will resend the patch shortly.

--
~Randy

2013-09-03 23:25:59

by Randy Dunlap

Subject: [PATCH v2] of_irq.h: fix build warnings when CONFIG_OF is not enabled

From: Randy Dunlap <[email protected]>

Fix build warnings when CONFIG_OF is not enabled:
(seen on i386 and x86_64)

include/linux/of_irq.h:82:7: warning: 'struct device_node' declared inside parameter list [enabled by default]
include/linux/of_irq.h:82:7: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
include/linux/of_irq.h:87:47: warning: 'struct device_node' declared inside parameter list [enabled by default]

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Grant Likely <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
---
include/linux/of_irq.h | 2 ++
1 file changed, 2 insertions(+)

--- linux-next-20130830.orig/include/linux/of_irq.h
+++ linux-next-20130830/include/linux/of_irq.h
@@ -1,6 +1,8 @@
#ifndef __OF_IRQ_H
#define __OF_IRQ_H

+struct device_node;
+
#if defined(CONFIG_OF)
struct of_irq;
#include <linux/types.h>