2013-09-05 07:03:16

by Duan Jiong

[permalink] [raw]

Subject: [PATCH] mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field

---

From: Duan Jiong <[email protected]>

Signed-off-by: Duan Jiong <[email protected]>
---
drivers/mtd/devices/bcm47xxsflash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/devices/bcm47xxsflash.c b/drivers/mtd/devices/bcm47xxsflash.c
index 18e7761..9b8aaf3 100644
--- a/drivers/mtd/devices/bcm47xxsflash.c
+++ b/drivers/mtd/devices/bcm47xxsflash.c
@@ -87,7 +87,7 @@ static int bcm47xxsflash_bcma_probe(struct platform_device *pdev)
return 0;

err_dev_reg:
- kfree(&b47s->mtd);
+ kfree(b47s);
out:
return err;
}
--
1.8.3.1

2013-09-05 08:36:48

by David Woodhouse

[permalink] [raw]

Subject: Re: [PATCH] mtd: bcm47xxsflash: the argument to kfree should not be the address of a structure field

---

On Thu, 2013-09-05 at 15:02 +0800, Duan Jiong wrote:

> err_dev_reg:
> - kfree(&b47s->mtd);
> + kfree(b47s);
> out:
> return err;
> }

Thanks, but this is already fixed in linux-next, and will be going to
Linus very shortly:

http://git.infradead.org/linux-mtd.git/commitdiff/d2b1bd1422

--
David Woodhouse Open Source Technology Centre
[email protected] Intel Corporation

---

Attachments:

smime.p7s (5.61 kB)