2013-09-09 15:34:58

by farisdehaan

Subject: [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed

From: Faris de Haan <[email protected]>

Fixed some of the coding style issues reported by checkpatch.pl

Signed-off-by: Faris de Haan <[email protected]>
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
index c2977be..cd3c9a7 100644
--- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
@@ -267,9 +267,8 @@ _func_enter_;

rtw_mfree_sta_priv_lock(pstapriv);

- if (pstapriv->pallocated_stainfo_buf) {
+ if (pstapriv->pallocated_stainfo_buf)
rtw_vmfree(pstapriv->pallocated_stainfo_buf, sizeof(struct sta_info)*NUM_STA+4);
- }
}

_func_exit_;
@@ -315,7 +314,7 @@ _func_enter_;

rtw_list_insert_tail(&psta->hash_list, phash_list);

- pstapriv->asoc_sta_count++ ;
+ pstapriv->asoc_sta_count++;

_exit_critical_bh(&(pstapriv->sta_hash_lock), &irql2);

@@ -419,7 +418,7 @@ _func_enter_;
_cancel_timer_ex(&psta->addba_retry_timer);

/* for A-MPDU Rx reordering buffer control, cancel reordering_ctrl_timer */
- for (i = 0; i < 16 ; i++) {
+ for (i = 0; i < 16; i++) {
unsigned long irql;
struct list_head *phead, *plist;
union recv_frame *prframe;
--
1.7.10.4

2013-09-09 16:10:24

by Larry Finger

Subject: Re: [PATCH] Staging: rtl8188eu: checkpatch.pl warnings removed

On 09/09/2013 10:34 AM, [email protected] wrote:
> From: Faris de Haan <[email protected]>
>
> Fixed some of the coding style issues reported by checkpatch.pl
>
> Signed-off-by: Faris de Haan <[email protected]>
> ---
> drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> index c2977be..cd3c9a7 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
> @@ -267,9 +267,8 @@ _func_enter_;
>
> rtw_mfree_sta_priv_lock(pstapriv);
>
> - if (pstapriv->pallocated_stainfo_buf) {
> + if (pstapriv->pallocated_stainfo_buf)
> rtw_vmfree(pstapriv->pallocated_stainfo_buf, sizeof(struct sta_info)*NUM_STA+4);
> - }
> }
>
> _func_exit_;
> @@ -315,7 +314,7 @@ _func_enter_;
>
> rtw_list_insert_tail(&psta->hash_list, phash_list);
>
> - pstapriv->asoc_sta_count++ ;
> + pstapriv->asoc_sta_count++;
>
> _exit_critical_bh(&(pstapriv->sta_hash_lock), &irql2);
>
> @@ -419,7 +418,7 @@ _func_enter_;
> _cancel_timer_ex(&psta->addba_retry_timer);
>
> /* for A-MPDU Rx reordering buffer control, cancel reordering_ctrl_timer */
> - for (i = 0; i < 16 ; i++) {
> + for (i = 0; i < 16; i++) {
> unsigned long irql;
> struct list_head *phead, *plist;
> union recv_frame *prframe;
>

Acked-by: Larry Finger <[email protected]>

Thanks,

Larry