2013-09-04 05:09:00

by Michael Opdenacker

[permalink] [raw]
Subject: [PATCH][RESEND] blackfin: remove unused parameters in Kconfig

This patch proposes to remove kernel configuration parameters
defined in arch/blackfin/Kconfig, but used nowhere
in the makefiles and source code.

This is an update for 3.11 of a patch already sent for 3.10

Signed-off-by: Michael Opdenacker <[email protected]>
---
arch/blackfin/Kconfig | 15 ---------------
1 file changed, 15 deletions(-)

diff --git a/arch/blackfin/Kconfig b/arch/blackfin/Kconfig
index 3b6abc5..4445758 100644
--- a/arch/blackfin/Kconfig
+++ b/arch/blackfin/Kconfig
@@ -861,14 +861,6 @@ config SYS_BFIN_SPINLOCK_L1
If enabled, sys_bfin_spinlock function is linked
into L1 instruction memory. (less latency)

-config IP_CHECKSUM_L1
- bool "Locate IP Checksum function in L1 Memory"
- default n
- depends on !SMP
- help
- If enabled, the IP Checksum function is linked
- into L1 instruction memory. (less latency)
-
config CACHELINE_ALIGNED_L1
bool "Locate cacheline_aligned data to L1 Data Memory"
default y if !BF54x
@@ -1330,13 +1322,6 @@ config PM_BFIN_WAKE_PB15
help
Enable PB15 Wake-Up

-config PM_BFIN_WAKE_PB15_POL
- int "Wake-up priority"
- depends on PM_BFIN_WAKE_PB15
- default 0
- help
- Wake-Up priority 0(low) 1(high)
-
config PM_BFIN_WAKE_PC15
bool "Allow Wake-Up from PC15"
depends on PM && BF60x
--
1.8.1.2


2013-09-12 08:25:22

by Michael Opdenacker

[permalink] [raw]
Subject: Re: [PATCH][RESEND] blackfin: remove unused parameters in Kconfig

Hi Steven,

Thank you for your replies!

On 09/12/2013 04:41 AM, Steven Miao wrote:
>
>
> On Wed, Sep 11, 2013 at 9:17 PM, Michael Opdenacker
> <[email protected]
> <mailto:[email protected]>> wrote:
>
> Hi Steven,
>
> Thank you for having a look at my patch!
>
> On 09/11/2013 11:25 AM, Steven Miao wrote:
> >
> >
> > -config PM_BFIN_WAKE_PB15_POL
> > - int "Wake-up priority"
> > - depends on PM_BFIN_WAKE_PB15
> > - default 0
> > - help
> > - Wake-Up priority 0(low) 1(high)
> > -
> >
> > this config will be used for wakeup pin PB15 priority on BF60x
>
> I don't understand how this config parameter is used. It isn't found
> *anywhere else* in the kernel source code.
>
> Is this parameter interpreted outside of the kernel build system? In
> user space for example?
>
> It will be used in bf609_cpu_pm_enter()
> @arch/blackfin/mach-bf609/pm.c. Have you updated your code to the
> latest revision? There was a typo in old revision.

Where can I find this new code? I just used Linus' tree, and I didn't
find PM_BFIN_WAKE_PB15_POL on
http://git.kernel.org/cgit/linux/kernel/git/lliubbo/blackfin.git/tree/arch/blackfin/mach-bf609/pm.c
either.

My apologies if I lack familiarity with the Blackfin project.

Cheers,

Michael.

--
Michael Opdenacker, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098

2013-09-12 10:14:49

by Michael Opdenacker

[permalink] [raw]
Subject: Re: [PATCH][RESEND] blackfin: remove unused parameters in Kconfig

On 09/12/2013 11:45 AM, Steven Miao wrote:

>
> The blackfin code repository has been moved to sourceforge for some
> commercial reasons now.
> You can ref:
> https://sourceforge.net/projects/adi-linux/
Good to know, thanks!

I've sent another patch to declare the corresponding repository in the
MAINTAINERS file.

Cheers,

Michael.

--
Michael Opdenacker, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098