2013-09-06 11:59:45

by Michael Opdenacker

[permalink] [raw]
Subject: [PATCH] m68k: remove unused Kconfig parameters

This patch proposes to remove the UC5282 and UC5272 kernel configuration
parameters defined in arch/m68k/Kconfig.machine,
but used nowhere in the makefiles and source code.

Signed-off-by: Michael Opdenacker <[email protected]>
---
arch/m68k/Kconfig.machine | 12 ------------
1 file changed, 12 deletions(-)

diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
index b9ab0a6..a10516b 100644
--- a/arch/m68k/Kconfig.machine
+++ b/arch/m68k/Kconfig.machine
@@ -150,18 +150,6 @@ config XCOPILOT_BUGS
help
Support the bugs of Xcopilot.

-config UC5272
- bool "Arcturus Networks uC5272 dimm board support"
- depends on M5272
- help
- Support for the Arcturus Networks uC5272 dimm board.
-
-config UC5282
- bool "Arcturus Networks uC5282 board support"
- depends on M528x
- help
- Support for the Arcturus Networks uC5282 dimm board.
-
config UCSIMM
bool "uCsimm module support"
depends on M68EZ328
--
1.8.1.2


2013-09-17 01:44:32

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH] m68k: remove unused Kconfig parameters

Hi Michael,

On 06/09/13 21:59, Michael Opdenacker wrote:
> This patch proposes to remove the UC5282 and UC5272 kernel configuration
> parameters defined in arch/m68k/Kconfig.machine,
> but used nowhere in the makefiles and source code.
>
> Signed-off-by: Michael Opdenacker <[email protected]>

This change is a subset of c065edde ("remove 16 unused boards in
Kconfig.machine") by Pauk Bolle. And that is in 3.12-rc1.

Thanks
Greg



> ---
> arch/m68k/Kconfig.machine | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/m68k/Kconfig.machine b/arch/m68k/Kconfig.machine
> index b9ab0a6..a10516b 100644
> --- a/arch/m68k/Kconfig.machine
> +++ b/arch/m68k/Kconfig.machine
> @@ -150,18 +150,6 @@ config XCOPILOT_BUGS
> help
> Support the bugs of Xcopilot.
>
> -config UC5272
> - bool "Arcturus Networks uC5272 dimm board support"
> - depends on M5272
> - help
> - Support for the Arcturus Networks uC5272 dimm board.
> -
> -config UC5282
> - bool "Arcturus Networks uC5282 board support"
> - depends on M528x
> - help
> - Support for the Arcturus Networks uC5282 dimm board.
> -
> config UCSIMM
> bool "uCsimm module support"
> depends on M68EZ328
>

2013-09-17 03:06:21

by Michael Opdenacker

[permalink] [raw]
Subject: Re: [PATCH] m68k: remove unused Kconfig parameters

Hi Greg,

On 09/17/2013 01:48 AM, Greg Ungerer wrote:
> Hi Michael,
>
> On 06/09/13 21:59, Michael Opdenacker wrote:
>> This patch proposes to remove the UC5282 and UC5272 kernel configuration
>> parameters defined in arch/m68k/Kconfig.machine,
>> but used nowhere in the makefiles and source code.
>>
>> Signed-off-by: Michael Opdenacker <[email protected]>
> This change is a subset of c065edde ("remove 16 unused boards in
> Kconfig.machine") by Pauk Bolle. And that is in 3.12-rc1.
Awesome! Thank you very much for the good news, and for not applying the
same change twice. Pfooh, this would have created anti-kconfig
parameters. Scary. ;)

Cheers,

Michael.

--
Michael Opdenacker, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098

2013-09-17 13:36:25

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH] m68k: remove unused Kconfig parameters

Hi Michael,

On 17/09/13 13:06, Michael Opdenacker wrote:
> On 09/17/2013 01:48 AM, Greg Ungerer wrote:
>> On 06/09/13 21:59, Michael Opdenacker wrote:
>>> This patch proposes to remove the UC5282 and UC5272 kernel configuration
>>> parameters defined in arch/m68k/Kconfig.machine,
>>> but used nowhere in the makefiles and source code.
>>>
>>> Signed-off-by: Michael Opdenacker <[email protected]>
>> This change is a subset of c065edde ("remove 16 unused boards in
>> Kconfig.machine") by Pauk Bolle. And that is in 3.12-rc1.
> Awesome! Thank you very much for the good news, and for not applying the
> same change twice. Pfooh, this would have created anti-kconfig
> parameters. Scary. ;)

That would be scary :-)

Regards
Greg