2013-09-25 19:50:06

by Gabor Juhos

[permalink] [raw]
Subject: [PATCH] avr32: fix compiler warning

The patch fixes the following compiler warning:
CC arch/avr32/kernel/process.o
arch/avr32/kernel/process.c: In function 'copy_thread':
arch/avr32/kernel/process.c:292: warning: assignment makes integer \
from pointer without a cast

Signed-off-by: Gabor Juhos <[email protected]>
---
Note: the patch is against v3.12-rc2.
---
arch/avr32/kernel/process.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/avr32/kernel/process.c b/arch/avr32/kernel/process.c
index c273100..42a53e74 100644
--- a/arch/avr32/kernel/process.c
+++ b/arch/avr32/kernel/process.c
@@ -289,7 +289,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
memset(childregs, 0, sizeof(struct pt_regs));
p->thread.cpu_context.r0 = arg;
p->thread.cpu_context.r1 = usp; /* fn */
- p->thread.cpu_context.r2 = syscall_return;
+ p->thread.cpu_context.r2 = (unsigned long)syscall_return;
p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
childregs->sr = MODE_SUPERVISOR;
} else {
--
1.7.10


Subject: Re: [PATCH] avr32: fix compiler warning

Around Wed 25 Sep 2013 21:50:01 +0200 or thereabout, Gabor Juhos wrote:

Tuning subject to

avr32: cast syscall_return to silence compiler warning

> The patch fixes the following compiler warning:
> CC arch/avr32/kernel/process.o
> arch/avr32/kernel/process.c: In function 'copy_thread':
> arch/avr32/kernel/process.c:292: warning: assignment makes integer \
> from pointer without a cast

Thank you for fixing.

> Signed-off-by: Gabor Juhos <[email protected]>

Acked-by: Hans-Christian Egtvedt <[email protected]>

> ---
> Note: the patch is against v3.12-rc2.

Added to my for-linus branch.

> ---
> arch/avr32/kernel/process.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/avr32/kernel/process.c b/arch/avr32/kernel/process.c
> index c273100..42a53e74 100644
> --- a/arch/avr32/kernel/process.c
> +++ b/arch/avr32/kernel/process.c
> @@ -289,7 +289,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp,
> memset(childregs, 0, sizeof(struct pt_regs));
> p->thread.cpu_context.r0 = arg;
> p->thread.cpu_context.r1 = usp; /* fn */
> - p->thread.cpu_context.r2 = syscall_return;
> + p->thread.cpu_context.r2 = (unsigned long)syscall_return;
> p->thread.cpu_context.pc = (unsigned long)ret_from_kernel_thread;
> childregs->sr = MODE_SUPERVISOR;
> } else {
--
mvh
Hans-Christian Egtvedt

2013-09-26 18:22:52

by Gabor Juhos

[permalink] [raw]
Subject: Re: [PATCH] avr32: fix compiler warning

2013.09.26. 8:18 keltez?ssel, Hans-Christian Egtvedt ?rta:
> Around Wed 25 Sep 2013 21:50:01 +0200 or thereabout, Gabor Juhos wrote:
>
> Tuning subject to
>
> avr32: cast syscall_return to silence compiler warning

This is indeed better, thanks.

>
>> The patch fixes the following compiler warning:
>> CC arch/avr32/kernel/process.o
>> arch/avr32/kernel/process.c: In function 'copy_thread':
>> arch/avr32/kernel/process.c:292: warning: assignment makes integer \
>> from pointer without a cast
>
> Thank you for fixing.
>
>> Signed-off-by: Gabor Juhos <[email protected]>
>
> Acked-by: Hans-Christian Egtvedt <[email protected]>
>
>> ---
>> Note: the patch is against v3.12-rc2.
>
> Added to my for-linus branch.

Thanks you!

-Gabor