2013-09-04 12:36:55

by Winkler, Tomas

Subject: [char-misc-next] hpet: remove useless check if fixmem32 is NULL

fixmem32 is assigned to address of res->data member
so the address is always valid

Actually since we are not checking for res != NULL
static analyzing is complaining about referencing the pointer
and consequent check for null.
The code snippet looks confusing also for human eyes.

Cc: Randy Dunlap <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
---
drivers/char/hpet.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 448ce5e..c8f4329 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -971,8 +971,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
struct acpi_resource_fixed_memory32 *fixmem32;

fixmem32 = &res->data.fixed_memory32;
- if (!fixmem32)
- return AE_NO_MEMORY;

hdp->hd_phys_address = fixmem32->address;
hdp->hd_address = ioremap(fixmem32->address,
--
1.8.3.1

2013-09-29 20:34:22

by Clemens Ladisch

Subject: [PATCH] hpet: remove useless check if fixmem32 is NULL

From: Tomas Winkler <[email protected]>

fixmem32 is assigned to address of res->data member
so the address is always valid

Actually since we are not checking for res != NULL
static analyzing is complaining about referencing the pointer
and consequent check for null.
The code snippet looks confusing also for human eyes.

Cc: Randy Dunlap <[email protected]>
Signed-off-by: Tomas Winkler <[email protected]>
Signed-off-by: Clemens Ladisch <[email protected]>
---
drivers/char/hpet.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index ab8651d..d6568a6 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -971,8 +971,6 @@ static acpi_status hpet_resources(struct acpi_resource *res, void *data)
struct acpi_resource_fixed_memory32 *fixmem32;

fixmem32 = &res->data.fixed_memory32;
- if (!fixmem32)
- return AE_NO_MEMORY;

hdp->hd_phys_address = fixmem32->address;
hdp->hd_address = ioremap(fixmem32->address,