2013-10-07 22:44:57

by Joe Perches

Subject: [PATCH] iscsi_iser: Add missing newlines to logging messages

Logging messages need terminating newlines to avoid
possible message interleaving. Add them.

Signed-off-by: Joe Perches <[email protected]>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers/infiniband/ulp/iser/iscsi_iser.c
index dd03cfe..dfb62e3 100644
--- a/drivers/infiniband/ulp/iser/iscsi_iser.c
+++ b/drivers/infiniband/ulp/iser/iscsi_iser.c
@@ -481,28 +481,28 @@ iscsi_iser_set_param(struct iscsi_cls_conn *cls_conn,
case ISCSI_PARAM_HDRDGST_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("DataDigest wasn't negotiated to None");
+ iser_err("DataDigest wasn't negotiated to None\n");
return -EPROTO;
}
break;
case ISCSI_PARAM_DATADGST_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("DataDigest wasn't negotiated to None");
+ iser_err("DataDigest wasn't negotiated to None\n");
return -EPROTO;
}
break;
case ISCSI_PARAM_IFMARKER_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("IFMarker wasn't negotiated to No");
+ iser_err("IFMarker wasn't negotiated to No\n");
return -EPROTO;
}
break;
case ISCSI_PARAM_OFMARKER_EN:
sscanf(buf, "%d", &value);
if (value) {
- iser_err("OFMarker wasn't negotiated to No");
+ iser_err("OFMarker wasn't negotiated to No\n");
return -EPROTO;
}
break;

2013-10-08 05:46:45

by Or Gerlitz

Subject: Re: [PATCH] iscsi_iser: Add missing newlines to logging messages

On 08/10/2013 01:44, Joe Perches wrote:
> Logging messages need terminating newlines to avoid
> possible message interleaving. Add them.
>
> Signed-off-by: Joe Perches<[email protected]>
> ---
Acked-by: Or Gerlitz <[email protected]>