2013-10-12 19:10:27

by Shawn Starr

Subject: No longer able to build kernel into RPM on Fedora

Hello folks,

My usual approach to testing git snapshots of Linus's tree (with custom
patches applied on top) is to make rpm and install this into my system for a
clean add/remove of test kernels.

However, the developers of rpm removed the --target and -ta options, so I
can't take tarball and build into RPM anymore.

Since I last built custom RPM builds of Linus's tree was likely Fedora 18, it
seems the option target got removed by 19.

Any ideas, fixes?

Thanks,
Shawn

2013-10-12 19:39:12

by Shawn Starr

Subject: [PATCH][BUILD] Force check for rpm-build where package is not installed

On Saturday, October 12, 2013 03:03:32 PM Shawn Starr wrote:
> Hello folks,
>
> My usual approach to testing git snapshots of Linus's tree (with custom
> patches applied on top) is to make rpm and install this into my system for a
> clean add/remove of test kernels.
>
> However, the developers of rpm removed the --target and -ta options, so I
> can't take tarball and build into RPM anymore.
>
> Since I last built custom RPM builds of Linus's tree was likely Fedora 18,
> it seems the option target got removed by 19.
>
> Any ideas, fixes?
>
> Thanks,
> Shawn

Sorry for noise, I was missing rpm-build. That said, here's a patch to force check for rpm-build as any modern RPM distribution should be be using a newer rpm release.

Thanks,
Shawn

Signed-off-by: Shawn Starr <[email protected]>
---
scripts/package/Makefile | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index a4f31c9..aac24de 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -23,7 +23,7 @@

# Do we have rpmbuild, otherwise fall back to the older rpm
RPM := $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
- else echo rpm; fi)
+ else echo none; fi)

# Remove hyphens since they have special meaning in RPM filenames
KERNELPATH := kernel-$(subst -,_,$(KERNELRELEASE))
@@ -51,6 +51,12 @@ rpm-pkg rpm: FORCE
rm -f $(objtree)/.scmversion
$(CONFIG_SHELL) $(srctree)/scripts/mkversion > $(objtree)/.tmp_version
mv -f $(objtree)/.tmp_version $(objtree)/.version
+ @if test "$(RPM)" != "rpmbuild"; then \
+ echo "To build the kernel you must install the rpm-build package from your distri
+ echo "aborting package creation." ; \
+ false; \
+ fi
+
$(RPM) $(RPMOPTS) --target $(UTS_MACHINE) -ta $(KERNELPATH).tar.gz
rm $(KERNELPATH).tar.gz kernel.spec

2013-10-12 19:42:11

by Shawn Starr

Subject: resend [PATCH][BUILD] Force check for rpm-build where package is not installed

On Saturday, October 12, 2013 03:39:05 PM Shawn Starr wrote:
> On Saturday, October 12, 2013 03:03:32 PM Shawn Starr wrote:
> > Hello folks,
> >
> > My usual approach to testing git snapshots of Linus's tree (with custom
> > patches applied on top) is to make rpm and install this into my system for
> > a clean add/remove of test kernels.
> >
> > However, the developers of rpm removed the --target and -ta options, so I
> > can't take tarball and build into RPM anymore.
> >
> > Since I last built custom RPM builds of Linus's tree was likely Fedora 18,
> > it seems the option target got removed by 19.
> >
> > Any ideas, fixes?
> >
> > Thanks,
> > Shawn
>
> Sorry for noise, I was missing rpm-build. That said, here's a patch to
> force check for rpm-build as any modern RPM distribution should be be using
> a newer rpm release.
>
> Thanks,
> Shawn
>

Signed-off-by: Shawn Starr <[email protected]>
---
scripts/package/Makefile | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index a4f31c9..aac24de 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -23,7 +23,7 @@

# Do we have rpmbuild, otherwise fall back to the older rpm
RPM := $(shell if [ -x "/usr/bin/rpmbuild" ]; then echo rpmbuild; \
- else echo rpm; fi)
+ else echo none; fi)

# Remove hyphens since they have special meaning in RPM filenames
KERNELPATH := kernel-$(subst -,_,$(KERNELRELEASE))
@@ -51,6 +51,12 @@ rpm-pkg rpm: FORCE
rm -f $(objtree)/.scmversion
$(CONFIG_SHELL) $(srctree)/scripts/mkversion > $(objtree)/.tmp_version
mv -f $(objtree)/.tmp_version $(objtree)/.version
+ @if test "$(RPM)" != "rpmbuild"; then \
+ echo "To build the kernel you must install the rpm-build
package from your distribution" ;\
+ echo "aborting package creation." ; \
+ false; \
+ fi
+
$(RPM) $(RPMOPTS) --target $(UTS_MACHINE) -ta $(KERNELPATH).tar.gz
rm $(KERNELPATH).tar.gz kernel.spec

2013-10-13 00:42:57

by Chris Jones

Subject: Re: No longer able to build kernel into RPM on Fedora

As a temporary work around, can you revert to the older version of RPM?


Regards




On 10/13/2013 05:03 AM, Shawn Starr wrote:
> Hello folks,
>
> My usual approach to testing git snapshots of Linus's tree (with custom
> patches applied on top) is to make rpm and install this into my system for a
> clean add/remove of test kernels.
>
> However, the developers of rpm removed the --target and -ta options, so I
> can't take tarball and build into RPM anymore.
>
> Since I last built custom RPM builds of Linus's tree was likely Fedora 18, it
> seems the option target got removed by 19.
>
> Any ideas, fixes?
>
> Thanks,
> Shawn
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>


--

Chris Jones

Founder and Lead Software Architect
Paradise Software
[email protected]

2013-10-13 01:19:22

by Shawn Starr

Subject: Re: No longer able to build kernel into RPM on Fedora

On Sunday, October 13, 2013 10:35:09 AM Chris Jones wrote:
> As a temporary work around, can you revert to the older version of RPM?
>

Hi Chris,

I was missing rpm-build, I have a patch submitted to force use of rpm-build.
AFAIK, nobody uses legacy rpm anymore since falling back to just rpm will fail
since it does not have --target or -ta options.

Thanks,
Shawn

>
> Regards
>
> On 10/13/2013 05:03 AM, Shawn Starr wrote:
> > Hello folks,
> >
> > My usual approach to testing git snapshots of Linus's tree (with custom
> > patches applied on top) is to make rpm and install this into my system for
> > a clean add/remove of test kernels.
> >
> > However, the developers of rpm removed the --target and -ta options, so I
> > can't take tarball and build into RPM anymore.
> >
> > Since I last built custom RPM builds of Linus's tree was likely Fedora 18,
> > it seems the option target got removed by 19.
> >
> > Any ideas, fixes?
> >
> > Thanks,
> > Shawn
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/