2013-10-16 00:29:34

by Felipe Pena

Subject: [PATCH] drivers: scsi: lpfc: Fix typo on NULL assignment

In the lpfc_ct_free_iocb function after freeing associated memory to the
ctiocb->context3, the ctiocb->context1 is set to NULL instead of context3.

Signed-off-by: Felipe Pena <[email protected]>
---
drivers/scsi/lpfc/lpfc_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
index 02e8cd9..da61d8d 100644
--- a/drivers/scsi/lpfc/lpfc_ct.c
+++ b/drivers/scsi/lpfc/lpfc_ct.c
@@ -280,7 +280,7 @@ lpfc_ct_free_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *ctiocb)
buf_ptr = (struct lpfc_dmabuf *) ctiocb->context3;
lpfc_mbuf_free(phba, buf_ptr->virt, buf_ptr->phys);
kfree(buf_ptr);
- ctiocb->context1 = NULL;
+ ctiocb->context3 = NULL;
}
lpfc_sli_release_iocbq(phba, ctiocb);
return 0;
--
1.7.10.4

2013-10-16 18:17:11

by James Smart

Subject: Re: [PATCH] drivers: scsi: lpfc: Fix typo on NULL assignment

Acked-by: James Smart <[email protected]>

-- james s


On 10/15/2013 8:29 PM, Felipe Pena wrote:
> In the lpfc_ct_free_iocb function after freeing associated memory to the
> ctiocb->context3, the ctiocb->context1 is set to NULL instead of context3.
>
> Signed-off-by: Felipe Pena <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_ct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c
> index 02e8cd9..da61d8d 100644
> --- a/drivers/scsi/lpfc/lpfc_ct.c
> +++ b/drivers/scsi/lpfc/lpfc_ct.c
> @@ -280,7 +280,7 @@ lpfc_ct_free_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *ctiocb)
> buf_ptr = (struct lpfc_dmabuf *) ctiocb->context3;
> lpfc_mbuf_free(phba, buf_ptr->virt, buf_ptr->phys);
> kfree(buf_ptr);
> - ctiocb->context1 = NULL;
> + ctiocb->context3 = NULL;
> }
> lpfc_sli_release_iocbq(phba, ctiocb);
> return 0;
> --
> 1.7.10.4
>
>