2021-02-03 02:52:44

by Yang Li

[permalink] [raw]
Subject: [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon

Eliminate the following coccicheck warning:
./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/pwm/pwm-lpc18xx-sct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c
index dc5133b..7ef4024 100644
--- a/drivers/pwm/pwm-lpc18xx-sct.c
+++ b/drivers/pwm/pwm-lpc18xx-sct.c
@@ -289,7 +289,7 @@ static int lpc18xx_pwm_request(struct pwm_chip *chip, struct pwm_device *pwm)
dev_err(lpc18xx_pwm->dev,
"maximum number of simultaneous channels reached\n");
return -EBUSY;
- };
+ }

set_bit(event, &lpc18xx_pwm->event_map);
lpc18xx_data->duty_event = event;
--
1.8.3.1


2021-02-03 07:47:23

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon

On Wed, Feb 03, 2021 at 10:50:05AM +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Acked-by: Uwe Kleine-K?nig <[email protected]>

But this is prior art:
https://lore.kernel.org/r/20210128134537.GA54687@068c7b848bbb

This patch is better though as it doesn't have a bogus Fixes: line.

*shrug*, I let Thierry decide which one to pick up.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (739.00 B)
signature.asc (499.00 B)
Download all attachments

2021-02-03 17:54:35

by Vladimir Zapolskiy

[permalink] [raw]
Subject: Re: [PATCH] pwm: lpc18xx-sct: remove unneeded semicolon

On 2/3/21 4:50 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Acked-by: Vladimir Zapolskiy <[email protected]>

--
Best wishes,
Vladimir