smps10 should be enabled only in the case of host mode. So stop
doing always_on, boot_on from smps10_out1. The driver will enable it in host
mode.
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/omap5-uevm.dts | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
index d784b3a..e06a04a 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -334,8 +334,6 @@
regulator-name = "smps10_out1";
regulator-min-microvolt = <5000000>;
regulator-max-microvolt = <5000000>;
- regulator-always-on;
- regulator-boot-on;
};
ldo1_reg: ldo1 {
--
1.7.10.4
From: George Cherian <[email protected]>
Added dr_mode property in dwc3 and set its default mode to device.
Signed-off-by: George Cherian <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
arch/arm/boot/dts/omap5.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 6d0a1d5..ef598af 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -652,6 +652,7 @@
reg = <0x4a030000 0x10000>;
interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
usb-phy = <&usb2_phy>, <&usb3_phy>;
+ dr_mode = "peripheral";
tx-fifo-resize;
};
};
--
1.7.10.4
On 16:19-20131010, Kishon Vijay Abraham I wrote:
> smps10 should be enabled only in the case of host mode. So stop
> doing always_on, boot_on from smps10_out1. The driver will enable it in host
> mode.
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index d784b3a..e06a04a 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -334,8 +334,6 @@
> regulator-name = "smps10_out1";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> - regulator-always-on;
> - regulator-boot-on;
> };
>
> ldo1_reg: ldo1 {
> --
Always good to get rid of regulator-always-on. Thanks for it.
regulator-boot-on indicates that PMIC enables it by default as part of
OTP or some internal behavior -> Looking at the measurements done on
uEVM and OTP information -> regulator-boot-on should be kept here.
Hence Nak.
--
Regards,
Nishanth Menon
On Thursday 10 October 2013 07:49 PM, Nishanth Menon wrote:
> On 16:19-20131010, Kishon Vijay Abraham I wrote:
>> smps10 should be enabled only in the case of host mode. So stop
>> doing always_on, boot_on from smps10_out1. The driver will enable it in host
>> mode.
>>
>> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
>> index d784b3a..e06a04a 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -334,8 +334,6 @@
>> regulator-name = "smps10_out1";
>> regulator-min-microvolt = <5000000>;
>> regulator-max-microvolt = <5000000>;
>> - regulator-always-on;
>> - regulator-boot-on;
>> };
>>
>> ldo1_reg: ldo1 {
>> --
> Always good to get rid of regulator-always-on. Thanks for it.
>
> regulator-boot-on indicates that PMIC enables it by default as part of
> OTP or some internal behavior -> Looking at the measurements done on
> uEVM and OTP information -> regulator-boot-on should be kept here.
No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb
driver to handle it.
Enabling it by default makes palmas-usb to detect VBUS interrupt. This should
ideally be detected only when you connect a host cable.
Btw I didn't exactly get why you want regulator-boot-on should be kept here.
Thanks
Kishon
On Fri, Oct 11, 2013 at 1:13 AM, Kishon Vijay Abraham I <[email protected]> wrote:
>
>> regulator-boot-on indicates that PMIC enables it by default as part of
>> OTP or some internal behavior -> Looking at the measurements done on
>> uEVM and OTP information -> regulator-boot-on should be kept here.
>
> No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb
> driver to handle it.
> Enabling it by default makes palmas-usb to detect VBUS interrupt. This should
> ideally be detected only when you connect a host cable.
> Btw I didn't exactly get why you want regulator-boot-on should be kept here.
binding description states:
- regulator-boot-on: bootloader/firmware enabled regulator
Further info: include/linux/regulator/machine.h
* @boot_on: Set if the regulator is enabled when the system is initially
* started. If the regulator is not enabled by the hardware or
* bootloader then it will be enabled when the constraints are
* applied.
What that means is that it is enabled by firmware/bootloader (in our
case One Time Program {OTP} inside Palmas) when the system switches on
even before the kernel starts. and we know SMPS10 is autoenabled by
Palmas OTP configuration even before first instruction in A15
executes.
I think you misunderstand this to mean that you'd like the regulator
to be *switched on* automatically at kernel boot by regulator
framework - there is no reasoning why we'd want such a binding since
we'd expect drivers to do their job of requesting and enabling
regulators on need..
Hope this helps. Let me know if I misunderstood something here.
Regards,
Nishanth Menon
Hi,
On Friday 11 October 2013 12:00 PM, Nishanth Menon wrote:
> On Fri, Oct 11, 2013 at 1:13 AM, Kishon Vijay Abraham I <[email protected]> wrote:
>>
>>> regulator-boot-on indicates that PMIC enables it by default as part of
>>> OTP or some internal behavior -> Looking at the measurements done on
>>> uEVM and OTP information -> regulator-boot-on should be kept here.
>>
>> No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb
>> driver to handle it.
>> Enabling it by default makes palmas-usb to detect VBUS interrupt. This should
>> ideally be detected only when you connect a host cable.
>> Btw I didn't exactly get why you want regulator-boot-on should be kept here.
>
> binding description states:
> - regulator-boot-on: bootloader/firmware enabled regulator
> Further info: include/linux/regulator/machine.h
> * @boot_on: Set if the regulator is enabled when the system is initially
> * started. If the regulator is not enabled by the hardware or
> * bootloader then it will be enabled when the constraints are
> * applied.
>
> What that means is that it is enabled by firmware/bootloader (in our
> case One Time Program {OTP} inside Palmas) when the system switches on
> even before the kernel starts. and we know SMPS10 is autoenabled by
> Palmas OTP configuration even before first instruction in A15
> executes.
Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I
tend to think that it might be OUT2 that's getting enabled by the OTP.
>
> I think you misunderstand this to mean that you'd like the regulator
> to be *switched on* automatically at kernel boot by regulator
> framework - there is no reasoning why we'd want such a binding since
> we'd expect drivers to do their job of requesting and enabling
> regulators on need..
The comment you just quoted tells it enables the regulator if its not enabled
by hardware. "If the regulator is not enabled by the hardware or bootloader
then it will be enabled when the constraints are applied." At-least that's what
I understood from that comment.
Also from our experiments it doesn't look like SMPS10_OUT1 is enabled by the
OTP and it gets enabled when we have *regulator-boot-on* constraints.
Thanks
Kishon
On Friday 11 October 2013 12:23 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Friday 11 October 2013 12:00 PM, Nishanth Menon wrote:
>> On Fri, Oct 11, 2013 at 1:13 AM, Kishon Vijay Abraham I <[email protected]> wrote:
>>>
>>>> regulator-boot-on indicates that PMIC enables it by default as part of
>>>> OTP or some internal behavior -> Looking at the measurements done on
>>>> uEVM and OTP information -> regulator-boot-on should be kept here.
>>>
>>> No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb
>>> driver to handle it.
>>> Enabling it by default makes palmas-usb to detect VBUS interrupt. This should
>>> ideally be detected only when you connect a host cable.
>>> Btw I didn't exactly get why you want regulator-boot-on should be kept here.
>>
>> binding description states:
>> - regulator-boot-on: bootloader/firmware enabled regulator
>> Further info: include/linux/regulator/machine.h
>> * @boot_on: Set if the regulator is enabled when the system is initially
>> * started. If the regulator is not enabled by the hardware or
>> * bootloader then it will be enabled when the constraints are
>> * applied.
>>
>> What that means is that it is enabled by firmware/bootloader (in our
>> case One Time Program {OTP} inside Palmas) when the system switches on
>> even before the kernel starts. and we know SMPS10 is autoenabled by
>> Palmas OTP configuration even before first instruction in A15
>> executes.
>
> Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I
> tend to think that it might be OUT2 that's getting enabled by the OTP.
>>
>> I think you misunderstand this to mean that you'd like the regulator
>> to be *switched on* automatically at kernel boot by regulator
>> framework - there is no reasoning why we'd want such a binding since
>> we'd expect drivers to do their job of requesting and enabling
>> regulators on need..
>
> The comment you just quoted tells it enables the regulator if its not enabled
> by hardware. "If the regulator is not enabled by the hardware or bootloader
> then it will be enabled when the constraints are applied." At-least that's what
> I understood from that comment.
>
> Also from our experiments it doesn't look like SMPS10_OUT1 is enabled by the
> OTP and it gets enabled when we have *regulator-boot-on* constraints.
btw.. I think this is the code in regulator fw that's responsible for enabling..
/* If the constraints say the regulator should be on at this point
* and we have control then make sure it is enabled.
*/
if ((rdev->constraints->always_on || rdev->constraints->boot_on) &&
ops->enable) {
ret = ops->enable(rdev);
if (ret < 0) {
rdev_err(rdev, "failed to enable\n");
goto out;
}
}
Thanks
Kishon
On Fri, Oct 11, 2013 at 1:54 AM, Kishon Vijay Abraham I <[email protected]> wrote:
> On Friday 11 October 2013 12:23 PM, Kishon Vijay Abraham I wrote:
>> Hi,
>>
>> On Friday 11 October 2013 12:00 PM, Nishanth Menon wrote:
>>> On Fri, Oct 11, 2013 at 1:13 AM, Kishon Vijay Abraham I <[email protected]> wrote:
>>>>
>>>>> regulator-boot-on indicates that PMIC enables it by default as part of
>>>>> OTP or some internal behavior -> Looking at the measurements done on
>>>>> uEVM and OTP information -> regulator-boot-on should be kept here.
>>>>
>>>> No. Actually I don?t want PMIC to enable it by default. I want the palmas-usb
>>>> driver to handle it.
>>>> Enabling it by default makes palmas-usb to detect VBUS interrupt. This should
>>>> ideally be detected only when you connect a host cable.
>>>> Btw I didn't exactly get why you want regulator-boot-on should be kept here.
>>>
>>> binding description states:
>>> - regulator-boot-on: bootloader/firmware enabled regulator
>>> Further info: include/linux/regulator/machine.h
>>> * @boot_on: Set if the regulator is enabled when the system is initially
>>> * started. If the regulator is not enabled by the hardware or
>>> * bootloader then it will be enabled when the constraints are
>>> * applied.
>>>
>>> What that means is that it is enabled by firmware/bootloader (in our
>>> case One Time Program {OTP} inside Palmas) when the system switches on
>>> even before the kernel starts. and we know SMPS10 is autoenabled by
>>> Palmas OTP configuration even before first instruction in A15
>>> executes.
>>
>> Not sure about that. Please note SMPS10 has two outputs OUT1 and OUT2 and I
>> tend to think that it might be OUT2 that's getting enabled by the OTP.
>>>
>>> I think you misunderstand this to mean that you'd like the regulator
>>> to be *switched on* automatically at kernel boot by regulator
>>> framework - there is no reasoning why we'd want such a binding since
>>> we'd expect drivers to do their job of requesting and enabling
>>> regulators on need..
>>
>> The comment you just quoted tells it enables the regulator if its not enabled
>> by hardware. "If the regulator is not enabled by the hardware or bootloader
>> then it will be enabled when the constraints are applied." At-least that's what
>> I understood from that comment.
>>
>> Also from our experiments it doesn't look like SMPS10_OUT1 is enabled by the
>> OTP and it gets enabled when we have *regulator-boot-on* constraints.
>
> btw.. I think this is the code in regulator fw that's responsible for enabling..
>
> /* If the constraints say the regulator should be on at this point
> * and we have control then make sure it is enabled.
> */
> if ((rdev->constraints->always_on || rdev->constraints->boot_on) &&
> ops->enable) {
> ret = ops->enable(rdev);
> if (ret < 0) {
> rdev_err(rdev, "failed to enable\n");
> goto out;
> }
> }
Drat, you are right, I did not really dig deep. thanks for correcting
my understanding here.
I propose the following change in binding as it seems completely
misleading to me.
diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt
b/Documentation/devicetree/bindings/regulator/regulator.txt
index 2bd8f09..d999f096 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.txt
+++ b/Documentation/devicetree/bindings/regulator/regulator.txt
@@ -8,7 +8,9 @@ Optional properties:
- regulator-min-microamp: smallest current consumers may set
- regulator-max-microamp: largest current consumers may set
- regulator-always-on: boolean, regulator should never be disabled
-- regulator-boot-on: bootloader/firmware enabled regulator
+- regulator-boot-on: regulator is enabled when the system is initially started.
+ If the regulator is not enabled by the hardware or bootloader then it will be
+ enabled when the constraints are applied.
- regulator-allow-bypass: allow the regulator to go into bypass mode
- <name>-supply: phandle to the parent supply/regulator node
- regulator-ramp-delay: ramp delay for regulator(in uV/uS)
Hi,
On 10/10/2013 01:49 PM, Kishon Vijay Abraham I wrote:
> From: George Cherian <[email protected]>
>
> Added dr_mode property in dwc3 and set its default mode to device.
If there is a specific reason why this is not set to "otg", we need
to explain it here.
AFAIK the port is meant to be used as OTG port.
>
> Signed-off-by: George Cherian <[email protected]>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> arch/arm/boot/dts/omap5.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 6d0a1d5..ef598af 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -652,6 +652,7 @@
> reg = <0x4a030000 0x10000>;
> interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
> usb-phy = <&usb2_phy>, <&usb3_phy>;
> + dr_mode = "peripheral";
> tx-fifo-resize;
> };
> };
>
cheers,
-roger
From: George Cherian <[email protected]>
Added dr_mode property in dwc3 and set its default mode to device.
Currently dwc3 driver doesn't have support for OTG mode. So explicitly
setting to peripheral even dwc3 is a OTG controller since OMAP5 has
already got an EHCI host.
Signed-off-by: George Cherian <[email protected]>
Signed-off-by: Kishon Vijay Abraham I <[email protected]>
---
Changes from v1:
Changed the commit log to explain why dr_mode was not set to OTG.
arch/arm/boot/dts/omap5.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 6d0a1d5..ef598af 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -652,6 +652,7 @@
reg = <0x4a030000 0x10000>;
interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
usb-phy = <&usb2_phy>, <&usb3_phy>;
+ dr_mode = "peripheral";
tx-fifo-resize;
};
};
--
1.7.10.4
Benoit,
On Tuesday 15 October 2013 11:19 AM, Kishon Vijay Abraham I wrote:
> From: George Cherian <[email protected]>
>
> Added dr_mode property in dwc3 and set its default mode to device.
> Currently dwc3 driver doesn't have support for OTG mode. So explicitly
> setting to peripheral even dwc3 is a OTG controller since OMAP5 has
> already got an EHCI host.
>
> Signed-off-by: George Cherian <[email protected]>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
Can you take this patch for 3.13?
Thanks
Kishon
> ---
> Changes from v1:
> Changed the commit log to explain why dr_mode was not set to OTG.
> arch/arm/boot/dts/omap5.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index 6d0a1d5..ef598af 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -652,6 +652,7 @@
> reg = <0x4a030000 0x10000>;
> interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
> usb-phy = <&usb2_phy>, <&usb3_phy>;
> + dr_mode = "peripheral";
> tx-fifo-resize;
> };
> };
>
Benoit,
On Thursday 10 October 2013 04:19 PM, Kishon Vijay Abraham I wrote:
> smps10 should be enabled only in the case of host mode. So stop
> doing always_on, boot_on from smps10_out1. The driver will enable it in host
> mode.
Can you take this patch too?
Thanks
Kishon
>
> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
> ---
> arch/arm/boot/dts/omap5-uevm.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
> index d784b3a..e06a04a 100644
> --- a/arch/arm/boot/dts/omap5-uevm.dts
> +++ b/arch/arm/boot/dts/omap5-uevm.dts
> @@ -334,8 +334,6 @@
> regulator-name = "smps10_out1";
> regulator-min-microvolt = <5000000>;
> regulator-max-microvolt = <5000000>;
> - regulator-always-on;
> - regulator-boot-on;
> };
>
> ldo1_reg: ldo1 {
>
On 10/16/2013 08:17 AM, Kishon Vijay Abraham I wrote:
> Benoit,
>
> On Thursday 10 October 2013 04:19 PM, Kishon Vijay Abraham I wrote:
>> smps10 should be enabled only in the case of host mode. So stop
>> doing always_on, boot_on from smps10_out1. The driver will enable it in host
>> mode.
>
> Can you take this patch too?
Acked-by: Nishanth Menon <[email protected]>
>
> Thanks
> Kishon
>>
>> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
>> ---
>> arch/arm/boot/dts/omap5-uevm.dts | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts
>> index d784b3a..e06a04a 100644
>> --- a/arch/arm/boot/dts/omap5-uevm.dts
>> +++ b/arch/arm/boot/dts/omap5-uevm.dts
>> @@ -334,8 +334,6 @@
>> regulator-name = "smps10_out1";
>> regulator-min-microvolt = <5000000>;
>> regulator-max-microvolt = <5000000>;
>> - regulator-always-on;
>> - regulator-boot-on;
>> };
>>
>> ldo1_reg: ldo1 {
>>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Regards,
Nishanth Menon
Hi Kishon,
On 16/10/2013 15:17, Kishon Vijay Abraham I wrote:
> Benoit,
>
> On Tuesday 15 October 2013 11:19 AM, Kishon Vijay Abraham I wrote:
>> From: George Cherian <[email protected]>
>>
>> Added dr_mode property in dwc3 and set its default mode to device.
>> Currently dwc3 driver doesn't have support for OTG mode. So explicitly
>> setting to peripheral even dwc3 is a OTG controller since OMAP5 has
>> already got an EHCI host.
>>
>> Signed-off-by: George Cherian <[email protected]>
>> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
>
> Can you take this patch for 3.13?
I've just applied it.
Thanks,
Benoit
--
Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
http://www.baylibre.com
Hi Kishon,
On 16/10/2013 15:27, Nishanth Menon wrote:
> On 10/16/2013 08:17 AM, Kishon Vijay Abraham I wrote:
>> Benoit,
>>
>> On Thursday 10 October 2013 04:19 PM, Kishon Vijay Abraham I wrote:
>>> smps10 should be enabled only in the case of host mode. So stop
>>> doing always_on, boot_on from smps10_out1. The driver will enable it in host
>>> mode.
>>
>> Can you take this patch too?
>
> Acked-by: Nishanth Menon <[email protected]>
I've just applied it.
Thanks,
Benoit
--
Beno?t Cousson
BayLibre
Embedded Linux Technology Lab
http://www.baylibre.com
On Friday 18 October 2013 01:38 AM, Benoit Cousson wrote:
> Hi Kishon,
>
> On 16/10/2013 15:17, Kishon Vijay Abraham I wrote:
>> Benoit,
>>
>> On Tuesday 15 October 2013 11:19 AM, Kishon Vijay Abraham I wrote:
>>> From: George Cherian <[email protected]>
>>>
>>> Added dr_mode property in dwc3 and set its default mode to device.
>>> Currently dwc3 driver doesn't have support for OTG mode. So explicitly
>>> setting to peripheral even dwc3 is a OTG controller since OMAP5 has
>>> already got an EHCI host.
>>>
>>> Signed-off-by: George Cherian <[email protected]>
>>> Signed-off-by: Kishon Vijay Abraham I <[email protected]>
>>
>> Can you take this patch for 3.13?
>
> I've just applied it.
Thanks :-)
-Kishon
>
> Thanks,
> Benoit
>
>
On Friday 18 October 2013 01:39 AM, Benoit Cousson wrote:
> Hi Kishon,
>
> On 16/10/2013 15:27, Nishanth Menon wrote:
>> On 10/16/2013 08:17 AM, Kishon Vijay Abraham I wrote:
>>> Benoit,
>>>
>>> On Thursday 10 October 2013 04:19 PM, Kishon Vijay Abraham I wrote:
>>>> smps10 should be enabled only in the case of host mode. So stop
>>>> doing always_on, boot_on from smps10_out1. The driver will enable it in host
>>>> mode.
>>>
>>> Can you take this patch too?
>>
>> Acked-by: Nishanth Menon <[email protected]>
>
> I've just applied it.
Thanks :-)
-Kishon
>
> Thanks,
> Benoit
>
>
On Fri, Oct 11, 2013 at 05:46:12PM +0300, Roger Quadros wrote:
> Hi,
>
> On 10/10/2013 01:49 PM, Kishon Vijay Abraham I wrote:
> > From: George Cherian <[email protected]>
> >
> > Added dr_mode property in dwc3 and set its default mode to device.
>
> If there is a specific reason why this is not set to "otg", we need
> to explain it here.
>
> AFAIK the port is meant to be used as OTG port.
we still don't have the workaround for dual role ports, I've been
working on it but still need to retest and make sure it's working fine
before merging upstream.
--
balbi
On Wed, Apr 16, 2014 at 11:16:19AM -0500, Felipe Balbi wrote:
> On Fri, Oct 11, 2013 at 05:46:12PM +0300, Roger Quadros wrote:
> > Hi,
> >
> > On 10/10/2013 01:49 PM, Kishon Vijay Abraham I wrote:
> > > From: George Cherian <[email protected]>
> > >
> > > Added dr_mode property in dwc3 and set its default mode to device.
> >
> > If there is a specific reason why this is not set to "otg", we need
> > to explain it here.
> >
> > AFAIK the port is meant to be used as OTG port.
>
> we still don't have the workaround for dual role ports, I've been
> working on it but still need to retest and make sure it's working fine
> before merging upstream.
man, I went back in time. Nevermind :-)
--
balbi