2013-10-21 21:22:50

by Jeff Mahoney

[permalink] [raw]
Subject: [PATCH] kobject: export kobj_sysfs_ops

struct kobj_attribute implements the baseline attribute functionality
that can be used all over the place. We should export the ops associated
with it. I have a series of patches on the linux-btrfs list that depend
on using kobj_sysfs_ops rather than re-implement them.

Signed-off-by: Jeff Mahoney <[email protected]>
---

lib/kobject.c | 1 +
1 file changed, 1 insertion(+)

--- a/lib/kobject.c 2013-10-21 16:09:51.868220920 -0400
+++ b/lib/kobject.c 2013-10-21 16:10:00.216037635 -0400
@@ -726,6 +726,7 @@ const struct sysfs_ops kobj_sysfs_ops =
.show = kobj_attr_show,
.store = kobj_attr_store,
};
+EXPORT_SYMBOL_GPL(kobj_sysfs_ops);

/**
* kset_register - initialize and add a kset.



--
Jeff Mahoney
SUSE Labs


2013-10-22 06:01:43

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] kobject: export kobj_sysfs_ops

On Mon, Oct 21, 2013 at 05:22:44PM -0400, Jeff Mahoney wrote:
> struct kobj_attribute implements the baseline attribute functionality
> that can be used all over the place. We should export the ops associated
> with it. I have a series of patches on the linux-btrfs list that depend
> on using kobj_sysfs_ops rather than re-implement them.

If you need this for other patches, would it be easier for you to just
take this patch with the btrfs patches so that there's no dependancy on
my tree for them?

If so, please add:

Signed-off-by: Greg Kroah-Hartman <[email protected]>

to this patch and pass it on, as I have no objection to it.

thanks,

greg k-h

2013-10-22 14:42:51

by Jeff Mahoney

[permalink] [raw]
Subject: Re: [PATCH] kobject: export kobj_sysfs_ops

On 10/22/13 2:03 AM, Greg KH wrote:
> On Mon, Oct 21, 2013 at 05:22:44PM -0400, Jeff Mahoney wrote:
>> struct kobj_attribute implements the baseline attribute functionality
>> that can be used all over the place. We should export the ops associated
>> with it. I have a series of patches on the linux-btrfs list that depend
>> on using kobj_sysfs_ops rather than re-implement them.
>
> If you need this for other patches, would it be easier for you to just
> take this patch with the btrfs patches so that there's no dependancy on
> my tree for them?

Yep. This patch is actually posted with that series on the linux-btrfs
list. I just wanted to get your S-o-b since it touches kobjects.

> If so, please add:
>
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
>
> to this patch and pass it on, as I have no objection to it.

Thanks!

-Jeff

--
Jeff Mahoney
SUSE Labs


Attachments:
signature.asc (841.00 B)
OpenPGP digital signature