2013-10-27 13:41:50

by Rob Pearce

[permalink] [raw]
Subject: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT

From: Rob Pearce <[email protected]>

These Intel D410PT and D425KT Mini-ITX desktop boards both show up as
having LVDS but the hardware is not populated. This patch adds them to
the list of such systems. Tested against 3.9.10 and 3.11.4

Signed-off-by: Rob Pearce <[email protected]>
---
diff -uprN -X linux-3.9.10/Documentation/dontdiff linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c
--- linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 19:00:30.000000000 +0100
+++ linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 18:58:56.000000000 +0100
@@ -843,6 +843,22 @@
},
{
.callback = intel_no_lvds_dmi_callback,
+ .ident = "Intel D410PT",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+ DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
+ },
+ },
+ {
+ .callback = intel_no_lvds_dmi_callback,
+ .ident = "Intel D425KT",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
+ DMI_MATCH(DMI_BOARD_NAME, "D425KT"),
+ },
+ },
+ {
+ .callback = intel_no_lvds_dmi_callback,
.ident = "Supermicro X7SPA-H",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),


2013-10-27 13:51:27

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT

On Sun, Oct 27, 2013 at 01:35:30PM +0000, Rob Pearce wrote:
> From: Rob Pearce <[email protected]>
>
> These Intel D410PT and D425KT Mini-ITX desktop boards both show up as
> having LVDS but the hardware is not populated. This patch adds them to
> the list of such systems. Tested against 3.9.10 and 3.11.4
>
> Signed-off-by: Rob Pearce <[email protected]>
> ---
> diff -uprN -X linux-3.9.10/Documentation/dontdiff linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c
> --- linux-3.9.10/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 19:00:30.000000000 +0100
> +++ linux-3.9.10-ovs/drivers/gpu/drm/i915/intel_lvds.c 2013-10-22 18:58:56.000000000 +0100
> @@ -843,6 +843,22 @@
> },
> {
> .callback = intel_no_lvds_dmi_callback,
> + .ident = "Intel D410PT",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
> + DMI_MATCH(DMI_BOARD_NAME, "D410PT"),
> + },
> + },
> + {
> + .callback = intel_no_lvds_dmi_callback,
> + .ident = "Intel D425KT",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
> + DMI_MATCH(DMI_BOARD_NAME, "D425KT"),

At least this one here has a KTW variant with lvds connector. I think we
need a DMI_EXACT_MATCH. I haven't found out whether the D410PT board also
has such a cousin, so please digg in a bit for me.

Thanks, Daniel

> + },
> + },
> + {
> + .callback = intel_no_lvds_dmi_callback,
> .ident = "Supermicro X7SPA-H",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "Supermicro"),
>

--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

2013-10-27 16:06:17

by Rob Pearce

[permalink] [raw]
Subject: Re: [PATCH] INTEL DRM DRIVERS : No LVDS hardware on Intel D410PT and D425KT

Hi Daniel,

On 27/10/13 13:51, Daniel Vetter wrote:
>> + .matches = {
>> > + DMI_MATCH(DMI_BOARD_VENDOR, "Intel"),
>> > + DMI_MATCH(DMI_BOARD_NAME, "D425KT"),
> At least this one here has a KTW variant with lvds connector. I think we
> need a DMI_EXACT_MATCH. I haven't found out whether the D410PT board also
> has such a cousin, so please digg in a bit for me.
>
Yes, you're right, sorry. I've had a dig and it looks like the D410PT
variants don't have LVDS (the differences in that range are legacy I/O,
PCIe and wireless). I'll re-submit with the 425 as an exact match.

Regards,
Rob