2013-10-28 03:50:50

by Chen Gang

Subject: [PATCH] arc: kernel: export symbol for pm_power_off in reset.c

Need export symbol for it, or can not pass compiling, the related error
with allmodconfig:

MODPOST 2994 modules
ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!


Signed-off-by: Chen Gang <[email protected]>
---
arch/arc/kernel/reset.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
index e227a2b..2768fa1 100644
--- a/arch/arc/kernel/reset.c
+++ b/arch/arc/kernel/reset.c
@@ -31,3 +31,4 @@ void machine_power_off(void)
}

void (*pm_power_off) (void) = NULL;
+EXPORT_SYMBOL(pm_power_off);
--
1.7.7.6

2013-10-28 04:10:48

by Chen Gang

Subject: Re: [PATCH] arc: kernel: export symbol for pm_power_off in reset.c

After this patch, and with limitations below, arc finishes allmodconfig.

- with EXTRA_CFLAGS=-mmedium-calls.

- disable CONFIG_CC_OPTIMIZE_FOR_SIZE.

- by pass 5-7 gcc issues (4-5 may duplicate).

- by pass 1 binutils issue (when disable CONFIG_CC_OPTIMIZE_FOR_SIZE).


Next (within 2013-10-31) I will/should:

- shrink cross-compilers information, at least.

- finish the patch for "portable assembler code - newline"


Left:

- it also content sevaval warnings (even not use "EXTRA_CFLAGS=-W").

- for next-20130927 tree, arc can not pass defconfig, either.

- not let it run under kvm (I don't know whether we support kvm).


Thanks.

On 10/28/2013 11:49 AM, Chen Gang wrote:
> Need export symbol for it, or can not pass compiling, the related error
> with allmodconfig:
>
> MODPOST 2994 modules
> ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
> ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/arc/kernel/reset.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
> index e227a2b..2768fa1 100644
> --- a/arch/arc/kernel/reset.c
> +++ b/arch/arc/kernel/reset.c
> @@ -31,3 +31,4 @@ void machine_power_off(void)
> }
>
> void (*pm_power_off) (void) = NULL;
> +EXPORT_SYMBOL(pm_power_off);
>


--
Chen Gang

2013-10-28 14:09:21

by Vineet Gupta

Subject: Re: [PATCH] arc: kernel: export symbol for pm_power_off in reset.c

On 10/28/2013 09:19 AM, Chen Gang wrote:
> Need export symbol for it, or can not pass compiling, the related error
> with allmodconfig:
>
> MODPOST 2994 modules
> ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
> ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
>
>
> Signed-off-by: Chen Gang <[email protected]>

Applied for 3.13

Thx,
-Vineet

2013-10-29 01:10:57

by Chen Gang

Subject: Re: [PATCH] arc: kernel: export symbol for pm_power_off in reset.c

On 10/28/2013 10:09 PM, Vineet Gupta wrote:
> On 10/28/2013 09:19 AM, Chen Gang wrote:
>> Need export symbol for it, or can not pass compiling, the related error
>> with allmodconfig:
>>
>> MODPOST 2994 modules
>> ERROR: "pm_power_off" [drivers/mfd/retu-mfd.ko] undefined!
>> ERROR: "pm_power_off" [drivers/char/ipmi/ipmi_poweroff.ko] undefined!
>>
>>
>> Signed-off-by: Chen Gang <[email protected]>
>
> Applied for 3.13
>

Thanks.
--
Chen Gang