2013-10-29 16:53:02

by Levente Kurusa

[permalink] [raw]
Subject: [PATCH RESEND] ACPI: Add Toshiba NB100 to Vista _OSI blacklist

This patch adds Toshiba NB100 to the Vista _OSI blacklist.

The _OSI(Windows 2006) method is bugged on the netbook resulting in messed up
PCI IRQ Routing information. This was observed on a netbook,
whose SATA controller mode was set to Compatibility mode.
The driver would then register itself to IRQ#16, but the device
was in fact issuing interrupts to IRQ#20.
No side-effects were found during testing, everything is
working as it did before.

See thread:
http://marc.info/?t=137862230200001&r=1&w=2
http://www.spinics.net/lists/linux-ide/msg46173.html


Signed-off-by: Levente Kurusa <[email protected]>
Reviewed-by: Robert Hancock <[email protected]>
---
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index cb96296..34d4d1a 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -267,6 +267,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
DMI_MATCH(DMI_PRODUCT_NAME, "Satellite P305D"),
},
},
+ {
+ .callback = dmi_disable_osi_vista,
+ .ident = "Toshiba NB100",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "NB100"),
+ },
+ },

/*
* BIOS invocation of _OSI(Linux) is almost always a BIOS bug.


2013-10-29 22:32:43

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH RESEND] ACPI: Add Toshiba NB100 to Vista _OSI blacklist

On Tuesday, October 29, 2013 05:52:56 PM Levente Kurusa wrote:
> This patch adds Toshiba NB100 to the Vista _OSI blacklist.
>
> The _OSI(Windows 2006) method is bugged on the netbook resulting in messed up
> PCI IRQ Routing information. This was observed on a netbook,
> whose SATA controller mode was set to Compatibility mode.
> The driver would then register itself to IRQ#16, but the device
> was in fact issuing interrupts to IRQ#20.
> No side-effects were found during testing, everything is
> working as it did before.
>
> See thread:
> http://marc.info/?t=137862230200001&r=1&w=2
> http://www.spinics.net/lists/linux-ide/msg46173.html
>
>
> Signed-off-by: Levente Kurusa <[email protected]>
> Reviewed-by: Robert Hancock <[email protected]>

That should be in linux-pm/linux-next already, isn't it there?

Rafael

2013-10-30 06:12:06

by Levente Kurusa

[permalink] [raw]
Subject: Re: [PATCH RESEND] ACPI: Add Toshiba NB100 to Vista _OSI blacklist

2013-10-29 23:44 keltezéssel, Rafael J. Wysocki írta:
> On Tuesday, October 29, 2013 05:52:56 PM Levente Kurusa wrote:
>> This patch adds Toshiba NB100 to the Vista _OSI blacklist.
>>
>> The _OSI(Windows 2006) method is bugged on the netbook resulting in messed up
>> PCI IRQ Routing information. This was observed on a netbook,
>> whose SATA controller mode was set to Compatibility mode.
>> The driver would then register itself to IRQ#16, but the device
>> was in fact issuing interrupts to IRQ#20.
>> No side-effects were found during testing, everything is
>> working as it did before.
>>
>> See thread:
>> http://marc.info/?t=137862230200001&r=1&w=2
>> http://www.spinics.net/lists/linux-ide/msg46173.html
>>
>>
>> Signed-off-by: Levente Kurusa <[email protected]>
>> Reviewed-by: Robert Hancock <[email protected]>
>
> That should be in linux-pm/linux-next already, isn't it there?

Hm, I didn't receive any reply back on the other mail, so I thought it got
lost somewhere. I see now that it has been applied, thanks and sorry for
the inconvenience.

--
Regards,
Levente Kurusa