2024-04-24 11:43:43

by Dan Carpenter

Subject: [PATCH] staging: vc04_services: Delete unnecessary NULL check

The "state" pointer points to an offset in the middle of the "mgmt"
struct so it can't possibly be NULL. And also we dereferenced it on the
line before. So this NULL check is pointless. Delete it.

Signed-off-by: Dan Carpenter <[email protected]>
---
.../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
index 9fe35864936c..3c63347d2d08 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
@@ -1170,11 +1170,6 @@ static int vchiq_open(struct inode *inode, struct file *file)

dev_dbg(state->dev, "arm: vchiq open\n");

- if (!state) {
- dev_err(state->dev, "arm: vchiq has no connection to VideoCore\n");
- return -ENOTCONN;
- }
-
instance = kzalloc(sizeof(*instance), GFP_KERNEL);
if (!instance)
return -ENOMEM;
--
2.43.0

2024-04-24 15:47:02

by Stefan Wahren

Subject: Re: [PATCH] staging: vc04_services: Delete unnecessary NULL check

Am 24.04.24 um 13:43 schrieb Dan Carpenter:
> The "state" pointer points to an offset in the middle of the "mgmt"
> struct so it can't possibly be NULL. And also we dereferenced it on the
> line before. So this NULL check is pointless. Delete it.
>
> Signed-off-by: Dan Carpenter <[email protected]>
Reviewed-by: Stefan Wahren <[email protected]>

Thanks

2024-04-25 06:38:22

by Umang Jain

Subject: Re: [PATCH] staging: vc04_services: Delete unnecessary NULL check

HI Dan,

Thank you for the patch

On 24/04/24 5:13 pm, Dan Carpenter wrote:
> The "state" pointer points to an offset in the middle of the "mgmt"
> struct so it can't possibly be NULL. And also we dereferenced it on the
> line before. So this NULL check is pointless. Delete it.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Reviewed-by: Umang Jain <[email protected]>
> ---
> .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> index 9fe35864936c..3c63347d2d08 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
> @@ -1170,11 +1170,6 @@ static int vchiq_open(struct inode *inode, struct file *file)
>
> dev_dbg(state->dev, "arm: vchiq open\n");
>
> - if (!state) {
> - dev_err(state->dev, "arm: vchiq has no connection to VideoCore\n");
> - return -ENOTCONN;
> - }
> -
> instance = kzalloc(sizeof(*instance), GFP_KERNEL);
> if (!instance)
> return -ENOMEM;