2013-10-29 19:22:51

by Joseph Salisbury

[permalink] [raw]
Subject: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

Hi Martin,

A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
it was found that reverting the following commit resolved this bug:

commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d
Author: Martin K. Petersen <[email protected]>
Date: Thu Jun 6 22:15:55 2013 -0400

[SCSI] sd: Update WRITE SAME heuristics


The regression was introduced as of v3.11-rc1, but it also made it's way
into the stable trees.

I see that you are the author of this patch, so I wanted to run this by
you. I was thinking of requesting a revert for v3.12, but I wanted to
get your feedback first.


Thanks,

Joe

[0] http://pad.lv/1237392


2013-10-29 19:42:21

by Douglas Gilbert

[permalink] [raw]
Subject: Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

On 13-10-29 03:21 PM, Joseph Salisbury wrote:
> Hi Martin,
>
> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
> it was found that reverting the following commit resolved this bug:
>
> commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d
> Author: Martin K. Petersen <[email protected]>
> Date: Thu Jun 6 22:15:55 2013 -0400
>
> [SCSI] sd: Update WRITE SAME heuristics
>
>
> The regression was introduced as of v3.11-rc1, but it also made it's way
> into the stable trees.
>
> I see that you are the author of this patch, so I wanted to run this by
> you. I was thinking of requesting a revert for v3.12, but I wanted to
> get your feedback first.
>
>
> Thanks,
>
> Joe
>
> [0] http://pad.lv/1237392

Tried the other approach?

From your bug report: "Areca Raid Controller2: F/W v1.46 ...(etc)..."

Then see:
http://www.areca.com.tw/support/main.htm

Doug Gilbert


2013-10-29 19:46:27

by Bernd Schubert

[permalink] [raw]
Subject: Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

Hello Joseph,

On 10/29/2013 08:21 PM, Joseph Salisbury wrote:
> Hi Martin,
>
> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
> it was found that reverting the following commit resolved this bug:
>
> commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d
> Author: Martin K. Petersen <[email protected]>
> Date: Thu Jun 6 22:15:55 2013 -0400
>
> [SCSI] sd: Update WRITE SAME heuristics
>
>
> The regression was introduced as of v3.11-rc1, but it also made it's way
> into the stable trees.
>
> I see that you are the author of this patch, so I wanted to run this by
> you. I was thinking of requesting a revert for v3.12, but I wanted to
> get your feedback first.
>

James queued this up for 3.13

> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42

Maybe we should try to convince James to take it into 3.12?


Cheers,
Bernd

2013-10-29 19:51:33

by Joseph Salisbury

[permalink] [raw]
Subject: Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

On 10/29/2013 03:46 PM, Bernd Schubert wrote:
> Hello Joseph,
>
> On 10/29/2013 08:21 PM, Joseph Salisbury wrote:
>> Hi Martin,
>>
>> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
>> it was found that reverting the following commit resolved this bug:
>>
>> commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d
>> Author: Martin K. Petersen <[email protected]>
>> Date: Thu Jun 6 22:15:55 2013 -0400
>>
>> [SCSI] sd: Update WRITE SAME heuristics
>>
>>
>> The regression was introduced as of v3.11-rc1, but it also made it's way
>> into the stable trees.
>>
>> I see that you are the author of this patch, so I wanted to run this by
>> you. I was thinking of requesting a revert for v3.12, but I wanted to
>> get your feedback first.
>>
>
> James queued this up for 3.13
>
>> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42
>>
>
> Maybe we should try to convince James to take it into 3.12?
>
>
> Cheers,
> Bernd

I'll build a 3.12 test kernel with this commit and ask the bug reporter
to test it. Thanks for the pointer, Bernd.

2013-10-29 19:54:16

by Joseph Salisbury

[permalink] [raw]
Subject: Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

On 10/29/2013 03:41 PM, Douglas Gilbert wrote:
> On 13-10-29 03:21 PM, Joseph Salisbury wrote:
>> Hi Martin,
>>
>> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
>> it was found that reverting the following commit resolved this bug:
>>
>> commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d
>> Author: Martin K. Petersen <[email protected]>
>> Date: Thu Jun 6 22:15:55 2013 -0400
>>
>> [SCSI] sd: Update WRITE SAME heuristics
>>
>>
>> The regression was introduced as of v3.11-rc1, but it also made it's way
>> into the stable trees.
>>
>> I see that you are the author of this patch, so I wanted to run this by
>> you. I was thinking of requesting a revert for v3.12, but I wanted to
>> get your feedback first.
>>
>>
>> Thanks,
>>
>> Joe
>>
>> [0] http://pad.lv/1237392
>
> Tried the other approach?
>
> From your bug report: "Areca Raid Controller2: F/W v1.46 ...(etc)..."
>
> Then see:
> http://www.areca.com.tw/support/main.htm
>
> Doug Gilbert
>
>
>
Thanks, Doug. I'm going to give the patch[0] written by Bernd Schubert
a try first. If the issue still persists, I'll ask the bug reporter to
upgrade the firmware.

[0]
http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42

2013-10-30 19:29:46

by Joseph Salisbury

[permalink] [raw]
Subject: Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

On 10/29/2013 03:46 PM, Bernd Schubert wrote:
> Hello Joseph,
>
> On 10/29/2013 08:21 PM, Joseph Salisbury wrote:
>> Hi Martin,
>>
>> A bug was opened against the Ubuntu kernel[0]. After a kernel bisect,
>> it was found that reverting the following commit resolved this bug:
>>
>> commit 66c28f97120e8a621afd5aa7a31c4b85c547d33d
>> Author: Martin K. Petersen <[email protected]>
>> Date: Thu Jun 6 22:15:55 2013 -0400
>>
>> [SCSI] sd: Update WRITE SAME heuristics
>>
>>
>> The regression was introduced as of v3.11-rc1, but it also made it's way
>> into the stable trees.
>>
>> I see that you are the author of this patch, so I wanted to run this by
>> you. I was thinking of requesting a revert for v3.12, but I wanted to
>> get your feedback first.
>>
>
> James queued this up for 3.13
>
>> http://git.kernel.org/cgit/linux/kernel/git/jejb/scsi.git/commit/?id=735e39e680256a13e7be3492acfb4d9721287a42
>>
>
> Maybe we should try to convince James to take it into 3.12?
>
>
> Cheers,
> Bernd
Hi Bernd,

The bug reporter confirms that your patch fixes the bug. Any chance
this patch can make it into 3.12?

Thanks,

Joe

2013-10-31 00:04:14

by H. Peter Anvin

[permalink] [raw]
Subject: Re: Subject: [v3.8][v3.11][Regression] [SCSI] sd: Update WRITE SAME heuristics

On 10/30/2013 12:28 PM, Joseph Salisbury wrote:
> Hi Bernd,
>
> The bug reporter confirms that your patch fixes the bug. Any chance
> this patch can make it into 3.12?

FWIW, I don't think reverting the WRITE SAME patch is an option -- it
causes serious filesystem failures.

-hpa