2013-10-31 01:55:08

by Chen Gang

Subject: [PATCH] openrisc: include: asm: define empty SERIAL_PORT_DFNS in serial.h

For some architectures (e.g. openrisc, arc), BASE_BAUD isn't constant
And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use
SERIAL_PORT_DFNS to initialize static variables, statically.

So need define SERIAL_PORT_DFNS as empty to tell drivers they don't
support SERIAL_PORT_DFNS (mostly like frv and parisc did).


Signed-off-by: Chen Gang <[email protected]>
---
arch/openrisc/include/asm/serial.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/openrisc/include/asm/serial.h b/arch/openrisc/include/asm/serial.h
index 270a452..254d1ad 100644
--- a/arch/openrisc/include/asm/serial.h
+++ b/arch/openrisc/include/asm/serial.h
@@ -31,6 +31,8 @@

#define BASE_BAUD (cpuinfo.clock_frequency/16)

+#define SERIAL_PORT_DFNS
+
#endif /* __KERNEL__ */

#endif /* __ASM_OPENRISC_SERIAL_H */
--
1.7.7.6

2013-10-31 06:59:50

by Chen Gang

Subject: Re: [PATCH] openrisc: include: asm: define empty SERIAL_PORT_DFNS in serial.h

On 10/31/2013 09:54 AM, Chen Gang wrote:
> For some architectures (e.g. openrisc, arc), BASE_BAUD isn't constant
> And SERIAL_PORT_DFNS always use BASE_BAUND, and also all drivers use
> SERIAL_PORT_DFNS to initialize static variables, statically.
>
> So need define SERIAL_PORT_DFNS as empty to tell drivers they don't
> support SERIAL_PORT_DFNS (mostly like frv and parisc did).
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/openrisc/include/asm/serial.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/serial.h b/arch/openrisc/include/asm/serial.h
> index 270a452..254d1ad 100644
> --- a/arch/openrisc/include/asm/serial.h
> +++ b/arch/openrisc/include/asm/serial.h
> @@ -31,6 +31,8 @@
>
> #define BASE_BAUD (cpuinfo.clock_frequency/16)
>
> +#define SERIAL_PORT_DFNS
> +
> #endif /* __KERNEL__ */
>
> #endif /* __ASM_OPENRISC_SERIAL_H */
>

Oh, sorry, this patch is incorrect, need fix within the driver.

Thanks.
--
Chen Gang